From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbcAPRK1 (ORCPT ); Sat, 16 Jan 2016 12:10:27 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:47030 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbcAPRKZ (ORCPT ); Sat, 16 Jan 2016 12:10:25 -0500 MIME-Version: 1.0 In-Reply-To: <1452785109-6172-12-git-send-email-maxime.ripard@free-electrons.com> References: <1452785109-6172-1-git-send-email-maxime.ripard@free-electrons.com> <1452785109-6172-12-git-send-email-maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Sun, 17 Jan 2016 01:10:02 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 11/26] ARM: sun5i: Add DRAM gates To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , David Airlie , Thierry Reding , Philipp Zabel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , dri-devel , linux-sunxi , Laurent Pinchart , Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Boris Brezillon , Wynter Woods , Thomas Petazzoni , Rob Clark , Daniel Vetter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 11:24 PM, Maxime Ripard wrote: > The DRAM gates control whether the image / display devices on the SoC have > access to the DRAM clock or not. > > Enable it. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/sun5i-a10s.dtsi | 7 ++++--- > arch/arm/boot/dts/sun5i-a13.dtsi | 2 +- > arch/arm/boot/dts/sun5i-r8.dtsi | 2 +- > arch/arm/boot/dts/sun5i.dtsi | 19 +++++++++++++++++++ > 4 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi > index bddd0de88af6..52d2c79cb37b 100644 > --- a/arch/arm/boot/dts/sun5i-a10s.dtsi > +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi > @@ -66,7 +66,7 @@ > "simple-framebuffer"; > allwinner,pipeline = "de_be0-lcd0-hdmi"; > clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>, > - <&ahb_gates 44>; > + <&ahb_gates 44>, <&dram_gates 26>; > status = "disabled"; > }; > > @@ -74,7 +74,8 @@ > compatible = "allwinner,simple-framebuffer", > "simple-framebuffer"; > allwinner,pipeline = "de_be0-lcd0"; > - clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 44>; > + clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 44>, > + <&dram_gates 26>; > status = "disabled"; > }; > > @@ -83,7 +84,7 @@ > "simple-framebuffer"; > allwinner,pipeline = "de_be0-lcd0-tve0"; > clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>, > - <&ahb_gates 44>; > + <&ahb_gates 44>, <&dram_gates 26>; > status = "disabled"; > }; > }; > diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi > index 9669b03f20f3..f29163650ca8 100644 > --- a/arch/arm/boot/dts/sun5i-a13.dtsi > +++ b/arch/arm/boot/dts/sun5i-a13.dtsi > @@ -62,7 +62,7 @@ > "simple-framebuffer"; > allwinner,pipeline = "de_be0-lcd0"; > clocks = <&ahb_gates 36>, <&ahb_gates 44>, <&de_be_clk>, > - <&tcon_ch0_clk>; > + <&tcon_ch0_clk>, <&dram_gates 26>; > status = "disabled"; > }; > }; > diff --git a/arch/arm/boot/dts/sun5i-r8.dtsi b/arch/arm/boot/dts/sun5i-r8.dtsi > index b1e4e0170d51..691d3de75b35 100644 > --- a/arch/arm/boot/dts/sun5i-r8.dtsi > +++ b/arch/arm/boot/dts/sun5i-r8.dtsi > @@ -53,7 +53,7 @@ > allwinner,pipeline = "de_be0-lcd0-tve0"; > clocks = <&ahb_gates 34>, <&ahb_gates 36>, > <&ahb_gates 44>, <&de_be_clk>, > - <&tcon_ch1_clk>; > + <&tcon_ch1_clk>, <&dram_gates 26>; > status = "disabled"; > }; > }; > diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi > index 0840612b5ed6..c72d94228915 100644 > --- a/arch/arm/boot/dts/sun5i.dtsi > +++ b/arch/arm/boot/dts/sun5i.dtsi > @@ -338,6 +338,25 @@ > clock-output-names = "usb_ohci0", "usb_phy"; > }; > > + dram_gates: clk@01c20100 { > + #clock-cells = <1>; > + compatible = "allwinner,sun5i-a13-dram-gates-clk"; > + reg = <0x01c20100 0x4>; > + clocks = <&pll5 0>; > + clock-indices = <0>, > + <1>, According to A10s manual, bit 3 is DRAM clock for TS (transport stream decoder), while bit 5 is for the TV encoder. The others look good. ChenYu > + <25>, > + <26>, > + <29>, > + <31>; > + clock-output-names = "dram_ve", > + "dram_csi", > + "dram_de_fe", > + "dram_de_be", > + "dram_ace", > + "dram_iep"; > + }; > + > codec_clk: clk@01c20140 { > #clock-cells = <0>; > compatible = "allwinner,sun4i-a10-codec-clk"; > -- > 2.6.4 >