From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbcBEJpt (ORCPT ); Fri, 5 Feb 2016 04:45:49 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:45850 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685AbcBEJpf (ORCPT ); Fri, 5 Feb 2016 04:45:35 -0500 MIME-Version: 1.0 In-Reply-To: <1454542430-16572-6-git-send-email-k@japko.eu> References: <1454542430-16572-1-git-send-email-k@japko.eu> <1454542430-16572-6-git-send-email-k@japko.eu> From: Chen-Yu Tsai Date: Fri, 5 Feb 2016 17:45:12 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set To: Krzysztof Adamski Cc: inus Walleij , Maxime Ripard , Chen-Yu Tsai , Hans de Goede , Lee Jones , Rob Herring , Jens Kuske , Fabian Frederick , Vishnu Patekar , "linux-gpio@vger.kernel.org" , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 4, 2016 at 7:33 AM, Krzysztof Adamski wrote: > sunxi_pmx_set accepts pin number and then calculates offset by > subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, > gets offset so we have to convert it to pin number so we won't get > negative value in sunxi_pmx_set. > > This was only used on A10 so far, where there is only one GPIO chip with > pin_base set to 0 so it didn't matter. However H3 also requires this > workaround but have two pinmux sections, triggering problem for PL port. > > Signed-off-by: Krzysztof Adamski Acked-by: Chen-Yu Tsai (resent as my mail setup failed to deliver)