From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Michael Chan <michael.chan@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH net-next] bnxt_en: flower: validate control flags
Date: Wed, 24 Apr 2024 14:44:15 +0530 [thread overview]
Message-ID: <CAHHeUGUHMGp9bxXk9FoMaNQD42gBxs5JpWpqaUKzm8LEHOB2yA@mail.gmail.com> (raw)
In-Reply-To: <CAHHeUGWsz=fhTSqnNiTphB5TRcf4ZyNsEov+vqtUEBiT+XCEag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2162 bytes --]
On Mon, Apr 22, 2024 at 10:51 PM Sriharsha Basavapatna
<sriharsha.basavapatna@broadcom.com> wrote:
>
> On Mon, Apr 22, 2024 at 8:58 PM Asbjørn Sloth Tønnesen <ast@fiberby.net> wrote:
> >
> > This driver currently doesn't support any control flags.
> >
> > Use flow_rule_match_has_control_flags() to check for control flags,
> > such as can be set through `tc flower ... ip_flags frag`.
> >
> > In case any control flags are masked, flow_rule_match_has_control_flags()
> > sets a NL extended error message, and we return -EOPNOTSUPP.
> >
> > Only compile-tested.
> >
> > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> > ---
> > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> > index 273c9ba48f09..d2ca90407cce 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> > @@ -370,6 +370,7 @@ static int bnxt_tc_parse_flow(struct bnxt *bp,
> > struct bnxt_tc_flow *flow)
> > {
> > struct flow_rule *rule = flow_cls_offload_flow_rule(tc_flow_cmd);
> > + struct netlink_ext_ack *extack = tc_flow_cmd->common.extack;
> > struct flow_dissector *dissector = rule->match.dissector;
> >
> > /* KEY_CONTROL and KEY_BASIC are needed for forming a meaningful key */
> > @@ -380,6 +381,9 @@ static int bnxt_tc_parse_flow(struct bnxt *bp,
> > return -EOPNOTSUPP;
> > }
> >
> > + if (flow_rule_match_has_control_flags(rule, extack))
> > + return -EOPNOTSUPP;
> > +
> > if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
> > struct flow_match_basic match;
> >
> > --
> > 2.43.0
> >
> >
>
> Thanks for this fix, it looks good. I need some time to test this; I
> will get back to you in a few days.
> -Harsha
Reviewed-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Tested-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4236 bytes --]
next prev parent reply other threads:[~2024-04-24 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 15:26 [PATCH net-next] bnxt_en: flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-22 17:21 ` Sriharsha Basavapatna
2024-04-24 9:14 ` Sriharsha Basavapatna [this message]
2024-04-23 12:56 ` Jiri Pirko
2024-04-25 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHHeUGUHMGp9bxXk9FoMaNQD42gBxs5JpWpqaUKzm8LEHOB2yA@mail.gmail.com \
--to=sriharsha.basavapatna@broadcom.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).