LKML Archive mirror
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: Add imx8mm-venice-gw7905-0x
Date: Wed, 19 Jul 2023 08:49:32 -0700	[thread overview]
Message-ID: <CAJ+vNU2e8Qe_XzzHt2Wm8ts91MvoDb_b=ie=5NbOtVJewCw3cw@mail.gmail.com> (raw)
In-Reply-To: <20230609174107.3373182-2-tharvey@gateworks.com>

On Fri, Jun 9, 2023 at 10:41 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> The Gateworks imx8mm-venice-gw7905-0x consists of a SOM + baseboard.
>
> The GW700x SOM contains the following:
>  - i.MX8M Mini SoC
>  - LPDDR4 memory
>  - eMMC Boot device
>  - Gateworks System Controller (GSC) with integrated EEPROM, button
>    controller, and ADC's
>  - PMIC
>  - SOM connector providing:
>   - FEC GbE MII
>   - 1x SPI
>   - 2x I2C
>   - 4x UART
>   - 2x USB 2.0
>   - 1x PCI
>   - 1x SDIO (4-bit 3.3V)
>   - 1x SDIO (4-bit 3.3V/1.8V)
>   - GPIO
>
> The GW7905 Baseboard contains the following:
>  - GPS
>  - microSD
>  - off-board I/O connector with I2C, SPI, GPIO
>  - EERPOM
>  - PCIe clock generator
>  - 1x full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0
>  - 1x half-length miniPCIe socket with USB2.0 and USB3.0
>  - USB 3.0 HUB
>  - USB Type-C with USB PD Sink capability and peripheral support
>  - USB Type-C with USB 3.0 host support
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> v2 - no changes
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../dts/freescale/imx8mm-venice-gw7905-0x.dts |  28 ++
>  .../dts/freescale/imx8mm-venice-gw7905.dtsi   | 303 ++++++++++++++++++
>  3 files changed, 332 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905-0x.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index d94d464db03e..f13faf043d48 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -73,6 +73,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7901.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7902.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7903.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7904.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7905-0x.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-verdin-nonwifi-dahlia.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-verdin-nonwifi-dev.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-verdin-nonwifi-yavia.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905-0x.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905-0x.dts
> new file mode 100644
> index 000000000000..914753f062cd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905-0x.dts
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2023 Gateworks Corporation
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mm.dtsi"
> +#include "imx8mm-venice-gw700x.dtsi"
> +#include "imx8mm-venice-gw7905.dtsi"
> +
> +/ {
> +       model = "Gateworks Venice GW7905-0x i.MX8MM Development Kit";
> +       compatible = "gateworks,imx8mm-gw7905-0x", "fsl,imx8mm";
> +
> +       chosen {
> +               stdout-path = &uart2;
> +       };
> +};
> +
> +/* Disable SOM interfaces not used on baseboard */
> +&fec1 {
> +       status = "disabled";
> +};
> +
> +&usdhc1 {
> +       status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905.dtsi
> new file mode 100644
> index 000000000000..9646eb9e4928
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7905.dtsi
> @@ -0,0 +1,303 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2023 Gateworks Corporation
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> +
> +/ {
> +       led-controller {
> +               compatible = "gpio-leds";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> +               led-0 {
> +                       function = LED_FUNCTION_STATUS;
> +                       color = <LED_COLOR_ID_GREEN>;
> +                       gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>;
> +                       default-state = "on";
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               led-1 {
> +                       function = LED_FUNCTION_STATUS;
> +                       color = <LED_COLOR_ID_RED>;
> +                       gpios = <&gpio4 2 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +               };
> +       };
> +
> +       pcie0_refclk: pcie0-refclk {
> +               compatible = "fixed-clock";
> +               #clock-cells = <0>;
> +               clock-frequency = <100000000>;
> +       };
> +
> +       pps {
> +               compatible = "pps-gpio";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_pps>;
> +               gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
> +               status = "okay";
> +       };
> +
> +       reg_usb2_vbus: regulator-usb2-vbus {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_reg_usb2_en>;
> +               compatible = "regulator-fixed";
> +               regulator-name = "usb2_vbus";
> +               gpio = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> +               enable-active-high;
> +               regulator-min-microvolt = <5000000>;
> +               regulator-max-microvolt = <5000000>;
> +       };
> +
> +       reg_usdhc2_vmmc: regulator-usdhc2 {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
> +               compatible = "regulator-fixed";
> +               regulator-name = "SD2_3P3V";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> +               enable-active-high;
> +       };
> +};
> +
> +/* off-board header */
> +&ecspi2 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_spi2>;
> +       cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> +       status = "okay";
> +};
> +
> +&gpio1 {
> +       gpio-line-names =
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "gpioa", "gpiob", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "";
> +};
> +
> +&gpio4 {
> +       gpio-line-names =
> +               "", "", "", "pci_usb_sel",
> +               "", "", "", "pci_wdis#",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "";
> +};
> +
> +&gpio5 {
> +       gpio-line-names =
> +               "", "", "", "",
> +               "gpioc", "gpiod", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "",
> +               "", "", "", "";
> +};
> +
> +&i2c2 {
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c2>;
> +       status = "okay";
> +
> +       eeprom@52 {
> +               compatible = "atmel,24c32";
> +               reg = <0x52>;
> +               pagesize = <32>;
> +       };
> +};
> +
> +/* off-board header */
> +&i2c3 {
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c3>;
> +       status = "okay";
> +};
> +
> +&pcie_phy {
> +       fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> +       fsl,clkreq-unsupported;
> +       clocks = <&pcie0_refclk>;
> +       clock-names = "ref";
> +       status = "okay";
> +};
> +
> +&pcie0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_pcie0>;
> +       reset-gpio = <&gpio4 6 GPIO_ACTIVE_LOW>;
> +       status = "okay";
> +};
> +
> +/* GPS */
> +&uart1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_uart1>;
> +       status = "okay";
> +};
> +
> +/* USB1 - Type C front panel SINK port J14 */
> +&usbotg1 {
> +       dr_mode = "peripheral";
> +       status = "okay";
> +};
> +
> +/* USB2 4-port USB3.0 HUB:
> + *  P1 - USBC connector (host only)
> + *  P2 - USB2 test connector
> + *  P3 - miniPCIe full card
> + *  P4 - miniPCIe half card
> + */
> +&usbotg2 {
> +       dr_mode = "host";
> +       vbus-supply = <&reg_usb2_vbus>;
> +       status = "okay";
> +};
> +
> +/* microSD */
> +&usdhc2 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +       pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> +       pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> +       cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> +       vmmc-supply = <&reg_usdhc2_vmmc>;
> +       bus-width = <4>;
> +       status = "okay";
> +};
> +
> +&iomuxc {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_hog>;
> +
> +       pinctrl_hog: hoggrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_GPIO1_IO13_GPIO1_IO13      0x40000040 /* GPIOA */
> +                       MX8MM_IOMUXC_GPIO1_IO14_GPIO1_IO14      0x40000040 /* GPIOB */
> +                       MX8MM_IOMUXC_SAI1_RXD1_GPIO4_IO3        0x40000106 /* PCI_USBSEL */
> +                       MX8MM_IOMUXC_SAI1_RXD5_GPIO4_IO7        0x40000106 /* PCIE_WDIS# */
> +                       MX8MM_IOMUXC_SPDIF_EXT_CLK_GPIO5_IO5    0x40000040 /* GPIOD */
> +                       MX8MM_IOMUXC_SPDIF_RX_GPIO5_IO4         0x40000040 /* GPIOC */
> +               >;
> +       };
> +
> +       pinctrl_gpio_leds: gpioledgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SAI1_RXFS_GPIO4_IO0        0x6     /* LEDG */
> +                       MX8MM_IOMUXC_SAI1_RXD0_GPIO4_IO2        0x6     /* LEDR */
> +               >;
> +       };
> +
> +       pinctrl_i2c2: i2c2grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL          0x400001c2
> +                       MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA          0x400001c2
> +               >;
> +       };
> +
> +       pinctrl_i2c3: i2c3grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL          0x400001c2
> +                       MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA          0x400001c2
> +               >;
> +       };
> +
> +       pinctrl_pcie0: pciegrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6        0x106
> +               >;
> +       };
> +
> +       pinctrl_pps: ppsgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SAI1_RXD3_GPIO4_IO5        0x106
> +               >;
> +       };
> +
> +       pinctrl_reg_usb2_en: regusb2grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8       0x6     /* USBHUB_RST# (ext p/u) */
> +               >;
> +       };
> +
> +       pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SD2_RESET_B_GPIO2_IO19     0x40
> +               >;
> +       };
> +
> +       pinctrl_spi2: spi2grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK    0x140
> +                       MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI    0x140
> +                       MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO    0x140
> +                       MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13      0x140
> +               >;
> +       };
> +
> +       pinctrl_uart1: uart1grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_UART1_RXD_UART1_DCE_RX     0x140
> +                       MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX     0x140
> +               >;
> +       };
> +
> +       pinctrl_usdhc2: usdhc2grp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x190
> +                       MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d0
> +                       MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d0
> +                       MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d0
> +                       MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d0
> +                       MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d0
> +                       MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0xc0
> +               >;
> +       };
> +
> +       pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x194
> +                       MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d4
> +                       MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d4
> +                       MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d4
> +                       MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d4
> +                       MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d4
> +                       MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0xc0
> +               >;
> +       };
> +
> +       pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK         0x196
> +                       MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD         0x1d6
> +                       MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d6
> +                       MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d6
> +                       MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d6
> +                       MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d6
> +                       MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0xc0
> +               >;
> +       };
> +
> +       pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12        0x1c4
> +               >;
> +       };
> +};
> --
> 2.25.1
>

Hi Shawn,

I'm not sure if you missed this one or if you had some rework that you wanted?

Best regards,

Tim

  reply	other threads:[~2023-07-19 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 17:41 [PATCH v2 1/2] dt-bindings: arm: Add Gateworks i.MX8M Mini GW7905-0x board Tim Harvey
2023-06-09 17:41 ` [PATCH v2 2/2] arm64: dts: freescale: Add imx8mm-venice-gw7905-0x Tim Harvey
2023-07-19 15:49   ` Tim Harvey [this message]
2023-06-10 16:36 ` [PATCH v2 1/2] dt-bindings: arm: Add Gateworks i.MX8M Mini GW7905-0x board Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+vNU2e8Qe_XzzHt2Wm8ts91MvoDb_b=ie=5NbOtVJewCw3cw@mail.gmail.com' \
    --to=tharvey@gateworks.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).