From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbcBKP6M (ORCPT ); Thu, 11 Feb 2016 10:58:12 -0500 Received: from mail-lb0-f193.google.com ([209.85.217.193]:33375 "EHLO mail-lb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbcBKP6F (ORCPT ); Thu, 11 Feb 2016 10:58:05 -0500 MIME-Version: 1.0 In-Reply-To: <20160211152935.GN6357@twins.programming.kicks-ass.net> References: <3071836.JbNxX8hU6x@vostro.rjw.lan> <56B93548.9090006@linaro.org> <5387313.xAhVpzgZCg@vostro.rjw.lan> <20160211115157.GH6357@twins.programming.kicks-ass.net> <20160211152935.GN6357@twins.programming.kicks-ass.net> Date: Thu, 11 Feb 2016 16:58:03 +0100 X-Google-Sender-Auth: Df_8eTseqv-euA8XfzGKlX_qZ1M Message-ID: Subject: Re: [PATCH 0/3] cpufreq: Replace timers with utilization update callbacks From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Steve Muckle , Linux PM list , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Juri Lelli , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 4:29 PM, Peter Zijlstra wrote: > On Thu, Feb 11, 2016 at 01:08:28PM +0100, Rafael J. Wysocki wrote: >> > Not really pretty though. It blows a bit that you require this callback >> > to be periodic (in order to replace a timer). >> >> We need it for now, but that's because of how things work on the cpufreq side. > > Right, maybe stick a big comment on cpufreq_trigger_update() noting its > a big ugly hack and will go away 'soon'. I will. >> The last version is here: >> >> https://patchwork.kernel.org/patch/8275271/ >> >> but it has the additional hooks for RT/DL which you seem to be >> thinking are a mistake. > > As long as we make sure everbody knows they're a band-aid and will be > taken out back and shot that should be fine for a little while I > suppose. Great, thanks! Yes, I'm treating those as a band-aid for replacement. Let me update the patch with a comment to explain that. Thanks, Rafael