From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbcBELxQ (ORCPT ); Fri, 5 Feb 2016 06:53:16 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36159 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752791AbcBELxO (ORCPT ); Fri, 5 Feb 2016 06:53:14 -0500 MIME-Version: 1.0 In-Reply-To: <20160204214045.1d6c2893@grimm.local.home> References: <1445278226-16187-1-git-send-email-0x7f454c46@gmail.com> <20160204214045.1d6c2893@grimm.local.home> From: Dmitry Safonov <0x7f454c46@gmail.com> Date: Fri, 5 Feb 2016 14:52:53 +0300 Message-ID: Subject: Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff To: Steven Rostedt Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-02-05 5:40 GMT+03:00 Steven Rostedt : > On Mon, 19 Oct 2015 21:10:26 +0300 > Dmitry Safonov <0x7f454c46@gmail.com> wrote: > >> There is no reason to do it twice: from commit b6f11df26fdc28 >> ("trace: Call tracing_reset_online_cpus before tracer->init()") >> resetting of per-CPU buffers done before tracer->init() call. >> >> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it >> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second >> time. >> It's slowpath, but anyway. > > Bah, I said I'd look at this and I did. But never added it to my queue. > It's not a big deal as this is the slow path but it makes sense. I knew > there was a patch from you to get but saw the TP_ARGS redefining patch > and thought that was it. Thanks, Steve! Yeah, I know it may take time to get to unimportant patches that are also mostly cleanups. Don't worry, please, take a glance when you'll have time on these small also not important cleanings (I'm fine if you'll drop them all): https://lkml.org/lkml/2015/11/20/290 https://lkml.org/lkml/2015/11/20/291 https://lkml.org/lkml/2015/10/30/580 > > I Cc'd myself on this to make sure I see it again. > > -- Steve -- Regards, Safonov Dmitry.