From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D5BC433B4 for ; Mon, 5 Apr 2021 20:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4E9D613C7 for ; Mon, 5 Apr 2021 20:11:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240637AbhDEULJ (ORCPT ); Mon, 5 Apr 2021 16:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235370AbhDEULF (ORCPT ); Mon, 5 Apr 2021 16:11:05 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8833DC061756; Mon, 5 Apr 2021 13:10:58 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id c15so2315872ilj.1; Mon, 05 Apr 2021 13:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yipPMaEHRBCVVLHFCEOHBoiBt4r0IqzPMd/p47fHFz8=; b=kXRuxDPCx2X1t6vPGgEQFce+rxUsWibPfNujCMhY4lrrhQE2hFCAksFpimzWUkV8gf b5i+XTx2jDeLrvQ0DCzyjwr1rq93K7ht8MaA+IkzzaNkQinH6zsNLhFSWHH0bvz1eCCV MMbzEK6fqiM5u1B6dydC80VAvqHepjKH2CxZFG4rTrwGrCIQCXVq27AQSO1he18AJNDz B1BskbqyayR3s2CezqEx3UDeBs9EXauCjDhD777+34ZcM52FpMWaN/OAhdW0kwr3czLy CPw+TTKpzmxwWHj5WyYP79ynDgHYuit9zBHjvQihnehwTSCLoqbDEpWMhJs/FKYz+hZ9 WW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yipPMaEHRBCVVLHFCEOHBoiBt4r0IqzPMd/p47fHFz8=; b=kSWIbuNiiXU4a5y00kxdVjAdpubCUvuol1KPFjZCkiObVHrFjRvyQYyuZ8jq1OIB3f NjJINhOwN8womnGIAeuRrmI7RPb+0Lb0snJXRQQGrSWbFrK2uuVIBdRY2GeCyw0Soj+v KtneofNKkoNgCjRfwkMD/K/d1Cjrpf0qE/gJwUq7po+6ToTvHMxqJivxHNORgPejhZQT W2bRP/W5tZavelLqzdFGDX+ZVQ/9EZWjNF7n4t5uZsnF6MPMTyRk1/HW+8OG/VcrpyUI 9E0cMNFZOqBvZYbQNQALs5a9QyzMGXzXW+fvqVKiDKgzh1u+RePNRgTbqYJSxRMfU2M1 TG3w== X-Gm-Message-State: AOAM533bCTcdC5wFwGp8jbczcLON670hTpgLjwLc7zWu1515gUHfEcOj UWwLHDtQpVAkZHF4z4EeXwvo6ry/IiQv7DjurD9QQ6URH55xW+wz X-Google-Smtp-Source: ABdhPJyUgVzb6RWclGt3JbqMEbsLVzUDNX+nBpGEUf004VfGHr05DyUKIhgb12qjPc2VShHEvczv9qGyLhf1wuQqowM= X-Received: by 2002:a05:6e02:104b:: with SMTP id p11mr20272403ilj.77.1617653457957; Mon, 05 Apr 2021 13:10:57 -0700 (PDT) MIME-Version: 1.0 References: <20210405031436.2465475-1-ilya.lipnitskiy@gmail.com> In-Reply-To: From: Ilya Lipnitskiy Date: Mon, 5 Apr 2021 13:10:47 -0700 Message-ID: Subject: Re: [PATCH] of: property: do not create device links from *nr-gpios To: Saravana Kannan Cc: Rob Herring , Frank Rowand , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , stable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, On Mon, Apr 5, 2021 at 1:01 PM Saravana Kannan wrote: > > On Sun, Apr 4, 2021 at 8:14 PM Ilya Lipnitskiy > wrote: > > > > [,]nr-gpios property is used by some GPIO drivers[0] to indicate > > the number of GPIOs present on a system, not define a GPIO. nr-gpios is > > not configured by #gpio-cells and can't be parsed along with other > > "*-gpios" properties. > > > > scripts/dtc/checks.c also has a special case for nr-gpio{s}. However, > > nr-gpio is not really special, so we only need to fix nr-gpios suffix > > here. > > The only example of this that I see is "snps,nr-gpios". arch/arm64/boot/dts/apm/apm-shadowcat.dtsi uses "apm,nr-gpios", with parsing code in drivers/gpio/gpio-xgene-sb.c. There is also code in drivers/gpio/gpio-adnp.c and drivers/gpio/gpio-mockup.c using "nr-gpios" without any vendor prefix. I personally don't think causing regressions is good for any reason, so I think we need to fix this in stable releases. The patch can be reverted when nr-gpios is no longer special. The logic here should also be aligned with scripts/dtc/checks.c, I actually submitted a patch to warn about "nr-gpios" only and not "nr-gpio" in dtc as well: https://www.spinics.net/lists/devicetree-compiler/msg03619.html Ilya