From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBEFC88CB4 for ; Mon, 12 Jun 2023 18:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237333AbjFLSPT (ORCPT ); Mon, 12 Jun 2023 14:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbjFLSPQ (ORCPT ); Mon, 12 Jun 2023 14:15:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D904A196 for ; Mon, 12 Jun 2023 11:15:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E31C62CAE for ; Mon, 12 Jun 2023 18:15:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D88B3C4339B for ; Mon, 12 Jun 2023 18:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686593714; bh=5VVyxM283nZurXcrJu3NkFtut1FZ/yTQ9dxSE9OavyA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DKOZ6Kp1scSEhJ5dYFZKi0n5vUjPdNQ4iRD119WiyOBSPKlZLFFGPAFGFrY9mzFTX SCUzL9XyZT53mky/qSIW6wDoc9LrJEj1ahMve48G5Gs1cGYtbveKcYkQ2K/p8Jh80l 40BlVVwBktZi67sc/C38GltyfbyZWS6sUCwxRIBVm3riEhzW4iIW0pt5fxMUxvbjZS hLnX2EPIHeTfBveLh9G5Tk2EzjdAkyXO3AFJtf0teTmEoIWdzTeIkRV6iWUzhqlmRC kKtgRAyM4ngRIqDiIqX5/z1r0TRWPuXlHEc0BXSRjZ1xCRzAdLhPzYPqANr8LAJ/yV Xn5SBiS6nxVMA== Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b219ed9915so54907551fa.3 for ; Mon, 12 Jun 2023 11:15:14 -0700 (PDT) X-Gm-Message-State: AC+VfDxOtbaiVGDoPRbLmqG06Zyfriar/v08Jn7Zxolq/3ZGben+Fk8e RCiAhKPUABd21uohEK48Jj2m826d73AINc4Hxg== X-Google-Smtp-Source: ACHHUZ6ovfpFOeZlPP4eF2X3MviCSbc9D8V33vQx/IVpA2iO/zgsRMO0jJiIqkYTV1Duqk7AccRU4D6T3M8xYOLaZqc= X-Received: by 2002:a2e:9ad1:0:b0:2a7:974d:a461 with SMTP id p17-20020a2e9ad1000000b002a7974da461mr3688248ljj.34.1686593712740; Mon, 12 Jun 2023 11:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20230410232647.1561308-1-robh@kernel.org> <0ce32e34-d53b-4038-ef39-3b0f3e2f8a7f@loongson.cn> In-Reply-To: <0ce32e34-d53b-4038-ef39-3b0f3e2f8a7f@loongson.cn> From: Rob Herring Date: Mon, 12 Jun 2023 12:15:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes To: Sui Jingfeng Cc: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 12:49=E2=80=AFAM Sui Jingfeng wrote: > > Reviewed-by: Sui Jingfeng > > > On 2023/6/10 04:17, Rob Herring wrote: > > On Mon, Apr 10, 2023 at 5:26=E2=80=AFPM Rob Herring w= rote: > >> Etnaviv doesn't use anything from of_platform.h, but depends on > >> of.h, of_device.h, and platform_device.h which are all implicitly > >> included, but that is going to be removed soon. > >> > >> Signed-off-by: Rob Herring > >> --- > >> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > > Ping! > > > of_device.h already has 'linux/of.h' and 'linux/platform_device.h' includ= ed, > > Would it be sufficient by simply including linux/of_device.h ? That's part of what I'm trying to remove. Standard practice is to not rely on implicit includes. Rob