From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030847AbbD1OCq (ORCPT ); Tue, 28 Apr 2015 10:02:46 -0400 Received: from mail-yh0-f42.google.com ([209.85.213.42]:35086 "EHLO mail-yh0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030229AbbD1OCo (ORCPT ); Tue, 28 Apr 2015 10:02:44 -0400 MIME-Version: 1.0 In-Reply-To: <553F91F8.3010400@hurleysoftware.com> References: <1428515119-25248-1-git-send-email-peter@hurleysoftware.com> <1428515119-25248-2-git-send-email-peter@hurleysoftware.com> <553F862A.2000709@hurleysoftware.com> <20150428132838.GA10782@kroah.com> <553F91F8.3010400@hurleysoftware.com> From: Rob Herring Date: Tue, 28 Apr 2015 09:02:23 -0500 Message-ID: Subject: Re: [PATCH v3 01/13] of: earlycon: Fix 'stdout-path' with ':' path terminator To: Peter Hurley Cc: Greg Kroah-Hartman , Rob Herring , Grant Likely , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kevin Cernekee , Leif Lindholm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2015 at 8:58 AM, Peter Hurley wrote: > On 04/28/2015 09:28 AM, Greg Kroah-Hartman wrote: >> On Tue, Apr 28, 2015 at 09:07:54AM -0400, Peter Hurley wrote: >>> On 04/08/2015 05:24 PM, Rob Herring wrote: >>>> On Wed, Apr 8, 2015 at 12:45 PM, Peter Hurley wrote: >>>>> stdout-path defines ':' as a path terminator and commit 75c28c09af99a >>>>> ("of: add optional options parameter to of_find_node_by_path()") added >>>>> the necessary support to parse paths terminated with ':'. >>>>> commit 7914a7c5651a5 ("of: support passing console options with >>>>> stdout-path") added options string support to the stdout-path property, >>>>> which broke earlycon. >>>>> >>>>> Add the same support to earlycon to process 'stdout-path' properties >>>>> which contain an options string. >>>>> >>>>> Requires: "libfdt: Add fdt_path_offset_namelen()" >>>> >>>> Since David has applied this, we can cherrypick that commit for the >>>> kernel copy. Ideally, we would do a dtc sync, but it's not going to >>>> happen for 4.1. >>> >>> Rob, >>> >>> Greg pulled this series for -next and kbuild robot promptly blew up >>> because of this missing commit. Are you planning on cherry-picking >>> "libfdt: Add fdt_path_offset_namelen()"? >> >> Can I just take that patch so I don't see the build issues in my branch? > > It's ok with me, fwiw. > > However, you should be aware that the patch is for the out-of-tree > devicetree compiler at git://git.kernel.org/pub/scm/utils/dtc/dtc.git, > which is not the same as in-tree compiler. > > I could send you an edited patch that applies cleanly to the > in-tree compiler but I don't know how Rob and Grant feel about that. That is what I suggested above if it was for 4.1. I would like to get a full sync of dtc done for 4.2 though. Give me a few days and I'll try to get that done. Rob