From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534CDEB64DB for ; Thu, 15 Jun 2023 14:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344901AbjFOOKp (ORCPT ); Thu, 15 Jun 2023 10:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbjFOOKl (ORCPT ); Thu, 15 Jun 2023 10:10:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B7A171C; Thu, 15 Jun 2023 07:10:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE5B86208A; Thu, 15 Jun 2023 14:10:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C07DC433C0; Thu, 15 Jun 2023 14:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686838239; bh=8FbUCp9ZN3V8nlIJvTpnnVtxiR20eH47E6H/M2tQXMQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ASgQIRayntAdT97tBYFV9Ia7GNoIxKYG1PmGtj1z29/XtQ1cFGks3JP6Gc1QuA8ZW jqh4SEPBCCnBi13+uima4zmtEXPLeXG16Pu/BYmnu2fBl8IyvgcNDPxfnp+ZVOsEuj PrYR40AjuV571ldWvTe27VbZ0AUPxNU0BLMf4URYRzdbPVyMFWMk4qNtzLTkO70/kw cjhJhkEDVx7R0p8s7LA4vsbFFmzq+7rreZV93cVBMBI/TuzCbO1nTm9Dt1y/6aKwII REpbMHZiVdLnG7cH12EXCg4fyvBe0frVGsMuNKiP3LoxsUpwsNzcP+92tN2DFM2O9a bclXr1gEv3t+g== Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b3451b3ea9so29594721fa.1; Thu, 15 Jun 2023 07:10:39 -0700 (PDT) X-Gm-Message-State: AC+VfDxr03xU8bwlboPRXgqEjzsU1vnJLPAWJR/9QlvxGR6Bam19n05P m813F5mpGNYNunELvT1umMqXTN9HMcwfgP8IHw== X-Google-Smtp-Source: ACHHUZ5l1G1VXSMGnsvMpM+q5vZFcFP4B+j6zelO+XbNie7OI/xbiGaNMzhkpNcb442P88SlAscXmNvERfy9/U37uAE= X-Received: by 2002:a2e:9846:0:b0:2b1:ac82:296 with SMTP id e6-20020a2e9846000000b002b1ac820296mr9302682ljj.34.1686838237226; Thu, 15 Jun 2023 07:10:37 -0700 (PDT) MIME-Version: 1.0 References: <20230609143609.209373-1-brgl@bgdev.pl> In-Reply-To: From: Rob Herring Date: Thu, 15 Jun 2023 08:10:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] of: unittest: drop assertions for GPIO hog messages To: Bartosz Golaszewski Cc: Frank Rowand , Linus Walleij , Andy Shevchenko , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 9, 2023 at 2:15=E2=80=AFPM Bartosz Golaszewski = wrote: > > On Fri, Jun 9, 2023 at 7:01=E2=80=AFPM Rob Herring w= rote: > > > > On Fri, Jun 9, 2023 at 8:36=E2=80=AFAM Bartosz Golaszewski wrote: > > > > > > From: Bartosz Golaszewski > > > > > > These have now been demoted to debug and are normally hidden. Drop th= e > > > assertions entirely. > > > > > > Suggested-by: Rob Herring > > > Signed-off-by: Bartosz Golaszewski > > > --- > > > drivers/of/unittest.c | 28 ---------------------------- > > > 1 file changed, 28 deletions(-) > > > > Why is this a separate patch? Don't I get at least 5 days to > > review/ack changes in drivers/of/? > > > > Sorry, my bad, I queued the previous one through the GPIO tree after > it was reviewed here thinking the unittests bits are trivial. I can > back it out if you insist or you can ack this one and the end effect > is the same? I will pay attention in the future. I'd prefer it to be squashed, but either way: Acked-by: Rob Herring