From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933438AbcBCUT7 (ORCPT ); Wed, 3 Feb 2016 15:19:59 -0500 Received: from mail.kernel.org ([198.145.29.136]:44925 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932849AbcBCUT4 (ORCPT ); Wed, 3 Feb 2016 15:19:56 -0500 MIME-Version: 1.0 In-Reply-To: <20160203195919.GB3327@lukather> References: <1452785109-6172-1-git-send-email-maxime.ripard@free-electrons.com> <1452785109-6172-18-git-send-email-maxime.ripard@free-electrons.com> <20160115031515.GA19797@rob-hp-laptop> <20160203195919.GB3327@lukather> From: Rob Herring Date: Wed, 3 Feb 2016 14:19:31 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 17/26] drm: sun4i: Add DT bindings documentation To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , David Airlie , Thierry Reding , Philipp Zabel , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-clk , dri-devel , linux-sunxi , Laurent Pinchart , Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Boris Brezillon , Wynter Woods , Thomas Petazzoni , Rob Clark , Daniel Vetter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 3, 2016 at 1:59 PM, Maxime Ripard wrote: > Hi Rob, > > On Thu, Jan 14, 2016 at 09:15:15PM -0600, Rob Herring wrote: >> On Thu, Jan 14, 2016 at 04:25:00PM +0100, Maxime Ripard wrote: >> > The display pipeline of the Allwinner A10 is involving several loosely >> > coupled components. >> > >> > Add a documentation for the bindings. >> > >> > Signed-off-by: Maxime Ripard >> > --- >> > .../bindings/display/sunxi/sun4i-drm.txt | 228 +++++++++++++++++++++ [...] >> > +Required properties: >> > + - compatible: value must be one of: >> > + * allwinner,sun5i-a13-display-engine >> > + - allwinner,pipelines: list of phandle to the entry points of the >> > + pipelines (either to the frontend or backend) >> > + >> > +Example: >> > + >> > +panel: panel { >> > + compatible = "olimex,lcd-olinuxino-43-ts"; >> >> This should either be a child of what it is attached to or use of-graph. > > You had a similar discussion with Thierry last time I sent it, and it > seemed to settle on keeping that property: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/382115.html > > Has that changed? No, I still disagree. We already have 2 ways to describe panels: as a child node of its controller or with of-graph. We don't need a 3rd way even if it is simple. The problem with of-graph today is too much of the parsing is left to the individual drivers. We need to fix that and make it be handled by common code. Rob