From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6154C13C3CB for ; Fri, 26 Apr 2024 07:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714116755; cv=none; b=U139w+I6BnPpcjK6zWoQwP1rQw+PgNpPMfdQfVAAv1ZYPv3DSrkq4XRFI8QC5ynak0GfCv0bkxJhuzmflUbS8Znq/sOedA2c4SwJZ9UoYSPcO2CGBBgf5d6eb1Pl4DFdTAYrlDCsxaRZjSXJ0pIm1Nb/DqVCvqNDVepErW+9ewM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714116755; c=relaxed/simple; bh=N+K4RoNFc+zB+X+QmQp6JiIrBFtjE+TzhQnlD2BBvMQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AMdHQdoLJ9/+J58xvBU+opWj+qfi6nJHS9hgIMQ5yMpOZrEpTsbw9moGuBu1OcRU8o1t93u55GQbJUG4cr/8i3LdjbniDRWysjnAM6Kof2gQB9YqDyeti6h6qzGskpnLBuZyiOJfdv+MzRbprfziTa7GuGnW0/d9SVokazBEzIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=u9exqb7n; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="u9exqb7n" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2dae975d0dcso30190851fa.1 for ; Fri, 26 Apr 2024 00:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1714116751; x=1714721551; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N+K4RoNFc+zB+X+QmQp6JiIrBFtjE+TzhQnlD2BBvMQ=; b=u9exqb7nBakiSvecNO+dmYaK7oBLCtP3JSYaZivMWqMQvmNL7RPRQXkOmTSB0fy9o8 uMvQ5cQjOuHqraXto91UAZC+rRNfnlTIb1ifCYN2OFNQAeFXN28UHd5lUYXlhSQIlNgk nKLgTua/wbVkLqzcfA+l3jnfvepyDmuHC4Gy+kYTVZm4h8mcNW2J9rCz763t35/uWK4C 9NqtOqazEfiO0UC2++H19zZWOi2kFmQK95ELl4tY3ianwjsq6DV8B//tjr+4XinIjCnb JIVs29Uh3htIpLt38/+BGtJfrphW1k+mCtDxXiUftRHuSNggwqrVGKJrLuftpvJEQeFS d/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714116751; x=1714721551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+K4RoNFc+zB+X+QmQp6JiIrBFtjE+TzhQnlD2BBvMQ=; b=OBYP1sRcRBg5AtaaNkAtbqRjoMsatSphcWFca6un3T2swLp2oivsqqGEMgv0l3PaM2 b48p0qCS3/8Q4+bLkGddhDwre21T9Jaf0hj6KI03yOlg4d3SFlAooThkdKtkAZWrfSYa wGrbwbAjoFlN1E/twVc2Nx8VvPqzXUUFkmtTeq3TIS3ZfE3ZS9x/XpE8++1t8oplzWMv K0smx0v1nL0kJQoJhCsxDqgDB/7FjdL925nOSonXOPYavWuxqUjoVQG65pxK7c9F8UuK k5yfP2o5BunMqjsr2aLfa4vNDni5wiS07AXuTApXG1771TGsNnKwSbjOMkayhePWD5W9 R7HQ== X-Forwarded-Encrypted: i=1; AJvYcCWNkSSDgQXaYdFsMM3zhbyrRUydSRqWmd2FbBJAIJdVWonCYMoUyRE2fIthBcdHNLRwbKMuii6OAkDBxHn2aOK/Lg3vYgbOWOccQPAJ X-Gm-Message-State: AOJu0Yzf+s3aEp+6FVPm5N/Uwpy3X2V5KrvoyRLNbQdXePHDIvAUsl8+ PYMKak2GVgysi2KXw5Xp0DHkQcZ1GCY2Mrj8vDqMAZ4pujmccV0zeLrrVv0ZcSR1vCh4mIOdBMa 1/4KClaILqfZvC6WXUXqy0ARHH+pMDLzvAFfe0Q== X-Google-Smtp-Source: AGHT+IFYGegiQeOjrbC7jab8L44FbjsL8B+Dm+eXafoa/lYhYMDXPnVhjneMaXH+VDajJaBZTMTFwcHDO4cfrTiAxXo= X-Received: by 2002:a2e:b163:0:b0:2de:6f52:5c8d with SMTP id a3-20020a2eb163000000b002de6f525c8dmr645023ljm.21.1714116751252; Fri, 26 Apr 2024 00:32:31 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240424185039.1707812-1-opendmb@gmail.com> <20240424185039.1707812-3-opendmb@gmail.com> In-Reply-To: <20240424185039.1707812-3-opendmb@gmail.com> From: Bartosz Golaszewski Date: Fri, 26 Apr 2024 09:32:20 +0200 Message-ID: Subject: Re: [PATCH 2/3] gpio: of: support gpio-ranges for multiple gpiochip devices To: Doug Berger Cc: Linus Walleij , Phil Elwell , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 24, 2024 at 8:51=E2=80=AFPM Doug Berger wro= te: > > Some drivers (e.g. gpio-mt7621 and gpio-brcmstb) have multiple > gpiochip banks within a single device. Unfortunately, the > gpio-ranges property of the device node was being applied to > every gpiochip of the device with device relative GPIO offset > values rather than gpiochip relative GPIO offset values. > > This commit makes use of the gpio_chip offset value which can be > non-zero for such devices to split the device node gpio-ranges > property into GPIO offset ranges that can be applied to each > of the relevant gpiochips of the device. > > Signed-off-by: Doug Berger > --- This is a good improvement, thanks! Bart