From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19773C7EE45 for ; Fri, 9 Jun 2023 20:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231143AbjFIUPq (ORCPT ); Fri, 9 Jun 2023 16:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbjFIUPn (ORCPT ); Fri, 9 Jun 2023 16:15:43 -0400 Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 174A72D5F for ; Fri, 9 Jun 2023 13:15:41 -0700 (PDT) Received: by mail-vs1-xe2b.google.com with SMTP id ada2fe7eead31-43b54597d3cso620728137.2 for ; Fri, 09 Jun 2023 13:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1686341740; x=1688933740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=raGvAg29sSFwcM9RybsJx6+tqHFKznCftHEYSM8PqQ4=; b=pPNHsRh9XiWRLgHB0psr+DFRlrIRviKoHNYjlD3Z2cAP6yYCcNYhAjkk4gy21UwZ5e t8KNonsK5yKuN/oy7DksWVDxaBxUsNCI44HBD2rpaVVUxooIdgVaBZrHDpgV+eMLT+qs 9oy2zhNURd+ECpyD92bcnVa8viSrPWkhYVYzvQTIczSgH8rhBnzfth76pw2wfWL39z+N CO92EIGZXp7n9l1uWigMJEUNLCsQa5Ct6RK3slYzQ6kviSoO8JybSKggVuS7Jmji6cGA /E5MXZRmswlRVAkRh0doAjJdla9rKLboqyGYeW/WL0OzxLFrhhoGD2zt6zl/MBpyqvL0 7QVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686341740; x=1688933740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=raGvAg29sSFwcM9RybsJx6+tqHFKznCftHEYSM8PqQ4=; b=iloZb4gwEc02EJ7j+bte1RuG73hTJvgo18rmBVOskYxOzPjelUF+PG1/QgHBeURIQn 4Su2qjca6PyAqA1HuZ5wLBrOn+nWl9TUxO3zWKEgTnsfj9mn9wP/0GAv/Xm7nUjtg0+f gOess29HuylCw7IrRK/2KFT4vGh7blaExW2SZf3Jv1hmpFpyDFMsG2jzazmSiLKiQvvp JXYF8nQrVWPLLtwQfIOI5aqgLgGnGFJuhZre2XdgmAiVqBYZjtbc72w6aetsl0M0Nul8 SqyJX6Fxb8xmBtxeSDXgq331FJq86sYpuII7M94rVCQAGyTZbJVGmIMUnkcOxWE8DKlp +SUA== X-Gm-Message-State: AC+VfDyLmCfF/RbJfc9nKIwb54URLMP2vecYYH2xqUqFEYT2ppFS+2Ov 5WuIpqv9VCKtiP/22DAS1Ejpg6/N76kMi/rdScZuhg== X-Google-Smtp-Source: ACHHUZ6buQWS9YCWGt3+h3H7ytmFRag705dKxxCwPKDrEa608VLfIidhHQ3FzwOdmHPVkkzqVsIHN/lz359RcfvV0DI= X-Received: by 2002:a67:f241:0:b0:43b:2551:5172 with SMTP id y1-20020a67f241000000b0043b25515172mr1263807vsm.24.1686341740176; Fri, 09 Jun 2023 13:15:40 -0700 (PDT) MIME-Version: 1.0 References: <20230609143609.209373-1-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 9 Jun 2023 22:15:29 +0200 Message-ID: Subject: Re: [PATCH] of: unittest: drop assertions for GPIO hog messages To: Rob Herring Cc: Frank Rowand , Linus Walleij , Andy Shevchenko , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 9, 2023 at 7:01=E2=80=AFPM Rob Herring wro= te: > > On Fri, Jun 9, 2023 at 8:36=E2=80=AFAM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > These have now been demoted to debug and are normally hidden. Drop the > > assertions entirely. > > > > Suggested-by: Rob Herring > > Signed-off-by: Bartosz Golaszewski > > --- > > drivers/of/unittest.c | 28 ---------------------------- > > 1 file changed, 28 deletions(-) > > Why is this a separate patch? Don't I get at least 5 days to > review/ack changes in drivers/of/? > Sorry, my bad, I queued the previous one through the GPIO tree after it was reviewed here thinking the unittests bits are trivial. I can back it out if you insist or you can ack this one and the end effect is the same? I will pay attention in the future. Bart