* [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes
@ 2024-07-09 11:33 Ma Ke
2024-07-09 12:10 ` Markus Elfring
2024-07-09 18:06 ` Patrik Jakobsson
0 siblings, 2 replies; 4+ messages in thread
From: Ma Ke @ 2024-07-09 11:33 UTC (permalink / raw)
To: patrik.r.jakobsson, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, daniel.vetter, alan, airlied, akpm
Cc: dri-devel, linux-kernel, Ma Ke, stable
In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_mode_duplicate(). Add a check to avoid npd.
Cc: stable@vger.kernel.org
Fixes: 6a227d5fd6c4 ("gma500: Add support for Cedarview")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
Changes in v4:
- revised the recipient email list, apologize for the inadvertent mistake.
Changes in v3:
- added the recipient's email address, due to the prolonged absence of a
response from the recipients.
Changes in v2:
- modified the patch according to suggestions from other patchs;
- added Fixes line;
- added Cc stable;
- Link: https://lore.kernel.org/lkml/20240622072514.1867582-1-make24@iscas.ac.cn/T/
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
index f08a6803dc18..3adc2c9ab72d 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
@@ -311,6 +311,9 @@ static int cdv_intel_lvds_get_modes(struct drm_connector *connector)
if (mode_dev->panel_fixed_mode != NULL) {
struct drm_display_mode *mode =
drm_mode_duplicate(dev, mode_dev->panel_fixed_mode);
+ if (!mode)
+ return 0;
+
drm_mode_probed_add(connector, mode);
return 1;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes
2024-07-09 11:33 [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes Ma Ke
@ 2024-07-09 12:10 ` Markus Elfring
2024-07-09 18:06 ` Patrik Jakobsson
1 sibling, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2024-07-09 12:10 UTC (permalink / raw)
To: make24, dri-devel, kernel-janitors
Cc: stable, LKML, Andrew Morton, Daniel Vetter, David Airlie,
Maarten Lankhorst, Maxime Ripard, Patrik Jakobsson,
Thomas Zimmermann, Wei Liu
…
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Are you going to adjust this information anyhow?
> ---
> Changes in v4:
> - revised the recipient email list, apologize for the inadvertent mistake.
…
The usage of mailing list addresses is probably undesirable for
the Developer's Certificate of Origin, isn't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n398
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes
2024-07-09 11:33 [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes Ma Ke
2024-07-09 12:10 ` Markus Elfring
@ 2024-07-09 18:06 ` Patrik Jakobsson
2024-07-10 8:34 ` [v4] " Markus Elfring
1 sibling, 1 reply; 4+ messages in thread
From: Patrik Jakobsson @ 2024-07-09 18:06 UTC (permalink / raw)
To: Ma Ke
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
daniel.vetter, alan, airlied, akpm, dri-devel, linux-kernel,
stable
On Tue, Jul 9, 2024 at 1:33 PM Ma Ke <make24@iscas.ac.cn> wrote:
>
> In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Cc: stable@vger.kernel.org
> Fixes: 6a227d5fd6c4 ("gma500: Add support for Cedarview")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Thanks for the patch!
Pushed to drm-misc-fixes
-Patrik
> ---
> Changes in v4:
> - revised the recipient email list, apologize for the inadvertent mistake.
> Changes in v3:
> - added the recipient's email address, due to the prolonged absence of a
> response from the recipients.
> Changes in v2:
> - modified the patch according to suggestions from other patchs;
> - added Fixes line;
> - added Cc stable;
> - Link: https://lore.kernel.org/lkml/20240622072514.1867582-1-make24@iscas.ac.cn/T/
> ---
> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> index f08a6803dc18..3adc2c9ab72d 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> @@ -311,6 +311,9 @@ static int cdv_intel_lvds_get_modes(struct drm_connector *connector)
> if (mode_dev->panel_fixed_mode != NULL) {
> struct drm_display_mode *mode =
> drm_mode_duplicate(dev, mode_dev->panel_fixed_mode);
> + if (!mode)
> + return 0;
> +
> drm_mode_probed_add(connector, mode);
> return 1;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes
2024-07-09 18:06 ` Patrik Jakobsson
@ 2024-07-10 8:34 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2024-07-10 8:34 UTC (permalink / raw)
To: Patrik Jakobsson, make24, dri-devel, kernel-janitors
Cc: stable, LKML, Andrew Morton, Daniel Vetter, David Airlie,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Wei Liu
…
> > Signed-off-by: Ma Ke <make24@iscas.ac.cn>
>
> Thanks for the patch!
> Pushed to drm-misc-fixes
Do you care for the applicability of the available information
according to this tag?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n398
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-10 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 11:33 [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes Ma Ke
2024-07-09 12:10 ` Markus Elfring
2024-07-09 18:06 ` Patrik Jakobsson
2024-07-10 8:34 ` [v4] " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).