From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28ED2C4742C for ; Tue, 3 Nov 2020 07:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9B4422384 for ; Tue, 3 Nov 2020 07:48:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bFV6uczO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727932AbgKCHsv (ORCPT ); Tue, 3 Nov 2020 02:48:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgKCHsu (ORCPT ); Tue, 3 Nov 2020 02:48:50 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15674C0617A6 for ; Mon, 2 Nov 2020 23:48:50 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id 205so4020470wma.4 for ; Mon, 02 Nov 2020 23:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tUGaeM8Mnf/FUCVI3KiAYmAdi9a2oLtRodyvcvLcqLs=; b=bFV6uczOZdEu2X41lTzQJm8V8VQDTE3pWtlE6Tp8MD+Nx1HjP+D0YYsHs6nPAeXR3/ hRKLZ+vkcnx+33fPceH+Pb7Mx0POz4pZcWqJK3Q98k/EetyMA/zmuhdTOj5fQ38nOc5H VxljblMI5DlEMaC4kAeMupEG0zY8ou1YC5IzarsvlUUxKbiti0So65SEtAU919xrb+f6 fH9E4L6M9i84V4XY5ZxvvvfMeac+k7afWr50fOGholdPzvlvcT9OSwnwsMdbZEgaN2U0 4uEBqi5UHHJy/lU4bBSTxyD6EWEqNjfMuhoM+5esqzhxazSYNm8QagucDMUPJRKEIz+s /EqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tUGaeM8Mnf/FUCVI3KiAYmAdi9a2oLtRodyvcvLcqLs=; b=RbVpy/50OQMJGg+dNqvWYRjkuyZhx1pCJLNn5Do7hR5tN6kWRHIkaPQzRowj8+Ltp3 NbbuBvnRpXhhF8tjIHELYLQqhaYBi1fQKk8fd9G20t7b21xCwd5aHDGnUgeyXKKMgP3t XzT56upH5YVSLIr1s65RUeq8xpe3I1c6+9/0ybSpDBR8iMkvkYXIsE4Mkkl0JkSsBmlV 3i4KST/MtNTZ9b5xnh3hj9s4LjiK+WvJvzKI8KgJLE77DwOpZkMpsckGvHfLxDDY+iEx 8qWbyYdtEIny4MSwkMeRQ3jUO+tfuxV7i4CxXRyETQ5EQy759Rv++0ZLsnkmOKN2HwYN Dyvg== X-Gm-Message-State: AOAM533AzwGzsejJpRYNQ+KrG1P4Ao60beuJ7vsgEgt9oJLKHIKVDAE4 eNE9NhtHRSdLxCHUt/YXAacG2vsv8xI3nqxTs+IxrQ== X-Google-Smtp-Source: ABdhPJx9ZcceuRnyasRN+tUhLDlW5agjweOQW/eO5nyTUhbn2MvXHT0gzlFn4Oww3KesuquyOtjOc0SLjijnLxJ94tE= X-Received: by 2002:a1c:1c1:: with SMTP id 184mr2149519wmb.16.1604389728675; Mon, 02 Nov 2020 23:48:48 -0800 (PST) MIME-Version: 1.0 References: <1601058581-19461-1-git-send-email-amit.pundir@linaro.org> <20200929190817.GA968845@bogus> <20201029134017.GA807@yoga> In-Reply-To: <20201029134017.GA807@yoga> From: Amit Pundir Date: Tue, 3 Nov 2020 13:18:12 +0530 Message-ID: Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests To: Bjorn Andersson Cc: Rob Herring , Kalle Valo , David S Miller , Jakub Kicinski , Jeffrey Hugo , John Stultz , Sumit Semwal , Konrad Dybcio , ath10k , dt , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Bjorn, Kalle, On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson wrote: > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > > There are firmware versions which do not support host capability > > > QMI request. We suspect either the host cap is not implemented or > > > there may be firmware specific issues, but apparently there seem > > > to be a generation of firmware that has this particular behavior. > > > > > > For example, firmware build on Xiaomi Poco F1 (sdm845) phone: > > > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1" > > > > > > If we do not skip the host cap QMI request on Poco F1, then we > > > get a QMI_ERR_MALFORMED_MSG_V01 error message in the > > > ath10k_qmi_host_cap_send_sync(). But this error message is not > > > fatal to the firmware nor to the ath10k driver and we can still > > > bring up the WiFi services successfully if we just ignore it. > > > > > > Hence introducing this DeviceTree quirk to skip host capability > > > QMI request for the firmware versions which do not support this > > > feature. > > > > So if you change the WiFi firmware, you may force a DT change too. Those > > are pretty independent things otherwise. > > > > Yes and that's not good. But I looked at somehow derive this from > firmware version numbers etc and it's not working out, so I'm out of > ideas for alternatives. > > > Why can't you just always ignore this error? If you can't deal with this > > entirely in the driver, then it should be part of the WiFi firmware so > > it's always in sync. > > > > Unfortunately the firmware versions I've hit this problem on has gone > belly up when receiving this request, that's why I asked Amit to add a > flag to skip it. So what is next for this DT quirk? I'm OK to go back to my previous of_machine_is_compatible() device specific hack, for now, https://patchwork.kernel.org/project/linux-wireless/patch/1600328501-8832-1-git-send-email-amit.pundir@linaro.org/ till we have a reasonable fix in place or receive a vendor firmware drop which fixes this problem (which I believe is highly unlikely though, for this 2+ years old device). Regards, Amit Pundir > > That said, in the devices I've hit this I've managed to get newer > firmware working, which doesn't have either problem. > > Regards, > Bjorn