From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F93C43460 for ; Thu, 20 May 2021 12:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39B3D61355 for ; Thu, 20 May 2021 12:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234553AbhETMhY (ORCPT ); Thu, 20 May 2021 08:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235016AbhETMhA (ORCPT ); Thu, 20 May 2021 08:37:00 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B75DC034634 for ; Thu, 20 May 2021 04:48:28 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id n4so3930495ybf.5 for ; Thu, 20 May 2021 04:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IzY+SQkfmVarzVl12JOqpF+g+vofysWXcmcw1n0tXyk=; b=kFilxWChMBWOdh2BWmPwnl879OJWmL6mRV0fowtUhReTcUISE9afvvX+wH6Ym1fUS7 BLpnEhNoYQuICVNMrTE/deWTQWDk8AGcGb5m/IoZWqWNx0SwH7B3L8ix/kywgRiJB8Fw DzWxuoapRNUPDjyXr6XRyV61FxdZjdaLj7JQsJf31LGat88dgZfcVjtwylhl/MgWys6q M6oyzcam4xHmzJE8TpKjZ3asbQjLXjQLEmBQcF+zGO68XLR3Qerq0wy3MC0xdS84V9yK a3r2xkxRDjXZ9AMnjnpiAWTFvK5P6QRSJDQTuaQ2dBVR/RLRtewY48J8od0baEPPXpVW itmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IzY+SQkfmVarzVl12JOqpF+g+vofysWXcmcw1n0tXyk=; b=iQYhcvT3s8zv9PsXx4HjjSj5APfA7JTa35kwUJ7Tpc4/nw8esHT7olM221pnZWIwFY aOxVF3fcOzJ9RHZ5XSmRZj/EqiiKMOV36tV0DQz+ZDJuZXT8B99Hj2V8HwXh8M+KcOKM dPhu2pphBogq4bAZUfIV0BT9S4uEaZVLZudQRQxYKbpy26xwAd2xwGSPXTDMGQkLCteG 5gzw0zqfLfD+yiSSK6Y+dGRLle1w3YeyX5HiwPX787vIWSqDLPD6IlRz0tygJeq79swD YQmBIwD1c76g5EAsNhGRaZ2iJAuMXFQZrTAXtmniWXLSg78f9MD8H7qfhib7dlgYOAbX xcmA== X-Gm-Message-State: AOAM532tp90WfB45uKytRCF8fvr4EmdU13v4YNuWvfHQuPVlHJWPIsQm +2LwVoQkQhodvvNQhleWyyl4F7QadI9lOVC7zpo4hg== X-Google-Smtp-Source: ABdhPJxLuyht98R9stDoeFxuz2RFWAB9bkdIq1ZZUcGkIlI+Ijs7qG26c8Uabkt9z7GuoUfJyb8UNAFfGKL38ajpVTs= X-Received: by 2002:a25:1fc2:: with SMTP id f185mr6327358ybf.258.1621511307687; Thu, 20 May 2021 04:48:27 -0700 (PDT) MIME-Version: 1.0 References: <1601058581-19461-1-git-send-email-amit.pundir@linaro.org> <20200929190817.GA968845@bogus> <20201029134017.GA807@yoga> <20201124175146.GG185852@builder.lan> <87sg8heeta.fsf@codeaurora.org> <87czxa4grv.fsf@codeaurora.org> <87blctveyj.fsf@codeaurora.org> In-Reply-To: <87blctveyj.fsf@codeaurora.org> From: Amit Pundir Date: Thu, 20 May 2021 17:17:52 +0530 Message-ID: Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests To: Kalle Valo , Bjorn Andersson , Rob Herring Cc: Jeffrey Hugo , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, lkml , ath10k , Konrad Dybcio , dt , David S Miller , John Stultz , Jakub Kicinski , Sumit Semwal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Reviving this old thread again, to check if there are still any hopes of landing this patch upstream. Based on the feedback I have got so far, there are no easy way to skip this part of the initialization at runtime. Bjorn and Kalle discussed the possibility of creating device specific firmware-N.bin firmware file but that would mean firmware-N.bin has to be loaded from the device-specific directory along with wlanmdsp.bin. And ideally making ath10k/ath11k in-charge of firmware loading, but there doesn't seem to be a consensus on this either(?) Regards, Amit Pundir On Tue, 9 Feb 2021 at 13:41, Kalle Valo wrote: > > Bjorn Andersson writes: > > > On Mon 08 Feb 11:21 CST 2021, Kalle Valo wrote: > > > >> Amit Pundir writes: > >> > >> > Hi Kalle, > >> > > >> > On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote: > >> >> > >> >> This is firmware version specific, right? There's also enum > >> >> ath10k_fw_features which is embedded within firmware-N.bin, we could add > >> >> a new flag there. But that means that a correct firmware-N.bin is needed > >> >> for each firmware version, not sure if that would work out. Just > >> >> throwing out ideas here. > >> > > >> > Apologies for this late reply. I was out for a while. > >> > >> No worries. > >> > >> > If by that (the firmware version) you mean "QC_IMAGE_VERSION_STRING", > >> > then that may be a bit tricky. Pocophone F1 use the same firmware > >> > family version (WLAN.HL.2.0.XXX), used by Dragonboard 845c (which has > >> > Wi-Fi working upstream). > >> > >> I'm meaning the ath10k firmware meta data we have in firmware-N.bin > >> (N=2,3,4...) file. A quick summary: > >> > >> Every ath10k firmware release should have firmware-N.bin. The file is > >> created with this tool: > >> > >> https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath10k/ath10k-fwencoder > >> > >> firmware-N.bin contains various metadata, one of those being firmware > >> feature flags: > >> > >> enum ath10k_fw_features { > >> /* wmi_mgmt_rx_hdr contains extra RSSI information */ > >> ATH10K_FW_FEATURE_EXT_WMI_MGMT_RX = 0, > >> > >> /* Firmware from 10X branch. Deprecated, don't use in new code. */ > >> ATH10K_FW_FEATURE_WMI_10X = 1, > >> > >> [...] > >> > >> So what you could is add a new flag enum ath10k_fw_features, create a > >> new firmware-N.bin for your device and enable the flag on the firmware > >> releases for your device only. > >> > >> I don't know if this is usable, but one solution which came to my mind. > > > > It sounds quite reasonable to pass this using firmawre-N.bin instead of > > DT, however that would imply that we need to find firmware-N.bin in the > > device-specific directory, where we keep the wlanmdsp.mbn as well - and > > not under /lib/firmware/ath10k > > > > For other devices (e.g. ADSP, modem or wlanmdsp.mbn) we're putting these > > in e.g. /lib/firmware/qcom/LENOVO/81JL/ and specifies the location using > > a firmware-name property in DT. > > Ah, I didn't realise that. > > Actually I would like to have ath10k in control[1] of QMI/rproc firmware > loading as the firmware releases have different constraints, like the > issue we are now discussing. Ideally firmware-N.bin would contain all > firmware files, for example wlanmdsp.mbn, and from the meta data > ath10k/ath11k would know what version of the firmware interface should > be used. > > I remember we discussed this briefly a year or two ago and there was no > easy solution, but I really wish we could find one. More these kind of > firmware interface incompatibilities will most likely pop up, also in > ath11k, so it would be great to find a clean and easily maneagable > solution. > > [1] With control I mean that ath10k/ath11k can choose which firmware > should be loaded > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches