From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDEEC43461 for ; Wed, 7 Apr 2021 20:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC15761159 for ; Wed, 7 Apr 2021 20:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349158AbhDGUMH (ORCPT ); Wed, 7 Apr 2021 16:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbhDGUMF (ORCPT ); Wed, 7 Apr 2021 16:12:05 -0400 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E38C061760 for ; Wed, 7 Apr 2021 13:11:55 -0700 (PDT) Received: by mail-vs1-xe31.google.com with SMTP id l8so10319503vsj.13 for ; Wed, 07 Apr 2021 13:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EXdgW9ChrKmdewwnery6En4MfPrzf/7Q8Ep2pcAMqUo=; b=HE+nrv5cu7TnTD1IfkoLvNgz6zakexccn0cKPSvik4Na3RVhOYykO4OkgPnxmrr8gx lIM885FJ4Y+eXBHVTfTPY6h3tqIs/Vtq7AxHG3QYbLpX2CzVnRDdawF89w7nGmtEfERi B1Q6Ld2nKCrNmlziO7N6UbSI+32yFpnOyy4EjwdfH0phzsozTj+KaJ4YWuUiBfHhEy5o cCssRoVWdzE8JK01WJ1InSkcRFMlxPBffm31kttZmzAemSNexvQXdFtRegFGytYloa2a /I7NTWTCnCJy4CgGuk9fU0loFJbda/wovnsOeKCRhOjxOZkI9IHhqG1oT8nnA9OZzWhr kw9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EXdgW9ChrKmdewwnery6En4MfPrzf/7Q8Ep2pcAMqUo=; b=c3iZ00K32Czd9sMfniKMuqV5MbErDPcq2bPOdRa4/9DVqg83+wzUlhUHQjyT20VjXR iGc+hx+ZXfaGQnNcFC4y7qQU67PKOv3G4u3i9JUnMvqqqSx0C6fhy9SuKTDXZYMu1B0/ PHV3x8migVzK8r5scAbyAXIi+lxaJ8MrJTFG/3p/F8Ud/5n9aC+x/OqIg7AL4zV11gcq 7w3fHBPQdqSjX67r5VpGwKqTmxWC6shsdAWaaiDnoMZ1AnNbar8jTxzf3TJ2QaoP4IZj kVUr9K2KkaDInb23ltJztY0lKCEEOerhHT+RHtCI6/IW4W+xnPzttctFFVrHOXWgzyoZ 1vWw== X-Gm-Message-State: AOAM5317QjfusjzH+4r9ypHZghZbKmFLKEQlkY8wUQjwC+J6ZeuDxeHx jfoO6XZSIAMIdjF7pky1Thq5o5kEN2nhpmdM9uwDJw== X-Google-Smtp-Source: ABdhPJwLiht0i7lb4LXnE2b7s5mj3mQSnxgyZI/JTwKWf2LwwCm8dPnbhJAsUghNAxifvHVnXjJCakjs/P76gv1sV4Q= X-Received: by 2002:a67:8c07:: with SMTP id o7mr3577176vsd.43.1617826314610; Wed, 07 Apr 2021 13:11:54 -0700 (PDT) MIME-Version: 1.0 References: <20210406013643.3280369-1-badhri@google.com> <20210406013643.3280369-4-badhri@google.com> In-Reply-To: From: Badhri Jagan Sridharan Date: Wed, 7 Apr 2021 13:11:19 -0700 Message-ID: Subject: Re: [PATCH v1 3/6] usb: typec: tcpm: update power supply once partner accepts To: Adam Thomson Cc: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyle Tso Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The reason for this change is missing in the patch description, >> or am I missing something ? Ah yes forgot to state this in the commit description which I have updated in V2. Removed a redundant power_supply_changed as one was already made a couple of lines before this one. Thanks, Badhri On Wed, Apr 7, 2021 at 9:08 AM Adam Thomson wrote: > > On 06 April 2021 02:37, Badhri Jagan Sridharan wrote: > > > power_supply_changed needs to be called to notify clients > > after the partner accepts the requested values for the pps > > case. > > > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through > > power_supply") > > Signed-off-by: Badhri Jagan Sridharan > > --- > > Missing commit information aside: > > Reviewed-by: Adam Thomson > > > drivers/usb/typec/tcpm/tcpm.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > > index d43774cc2ccf..7708b01009cb 100644 > > --- a/drivers/usb/typec/tcpm/tcpm.c > > +++ b/drivers/usb/typec/tcpm/tcpm.c > > @@ -2564,6 +2564,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port > > *port, > > port->pps_data.max_curr = port- > > >pps_data.req_max_curr; > > port->req_supply_voltage = port- > > >pps_data.req_out_volt; > > port->req_current_limit = port->pps_data.req_op_curr; > > + power_supply_changed(port->psy); > > tcpm_set_state(port, SNK_TRANSITION_SINK, 0); > > break; > > case SOFT_RESET_SEND: > > @@ -3132,7 +3133,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct > > tcpm_port *port) > > port- > > >pps_data.req_out_volt)); > > port->pps_data.req_op_curr = min(port->pps_data.max_curr, > > port->pps_data.req_op_curr); > > - power_supply_changed(port->psy); > > } > > > > return src_pdo; > > @@ -3557,8 +3557,6 @@ static void tcpm_reset_port(struct tcpm_port *port) > > port->sink_cap_done = false; > > if (port->tcpc->enable_frs) > > port->tcpc->enable_frs(port->tcpc, false); > > - > > - power_supply_changed(port->psy); > > } > > > > static void tcpm_detach(struct tcpm_port *port) > > -- > > 2.31.0.208.g409f899ff0-goog >