From: Gwendal Grignou <gwendal@chromium.org>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Gwendal Grignou <gwendal@google.com>
Subject: Re: [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute after sensors are found
Date: Wed, 4 Aug 2021 14:09:37 -0700 [thread overview]
Message-ID: <CAPUE2utqRi9+Rb3UPE6FFRVoKDE5z+NFk1TL5Nmb7CW-VpBK=A@mail.gmail.com> (raw)
In-Reply-To: <CAE_wzQ-bMhrH7pcwNRRTgLFD3opYE2UriU_N=-bu+neq8MHFrQ@mail.gmail.com>
The v2 patches I submitted were wrong, as cros_ec sysfs driver is
modifying the attributes of the class driver, not its own. I repost a
patch that takes that into account.
Gwendal.
On Sun, May 30, 2021 at 10:36 PM Dmitry Torokhov <dtor@chromium.org> wrote:
>
> Hi Gwendal,
>
> On Thu, May 27, 2021 at 2:01 PM Gwendal Grignou <gwendal@chromium.org> wrote:
> >
> > [+dtor]
> > Is this change acceptable? I was worried it could break when
> > asynchronous probing is used [https://lwn.net/Articles/629895/], but
> > since all probes are deferred in a single thread, it is safe.
>
> I think this is a bit awkward that we need to poke a separate sub-driver.
>
> Have you considered having cros_ec_sensorhub.c create its own
> attribute group (it does not have to have a name and it looks like one
> can register as many unnamed groups as they want) and have wake angle
> show and store methods directly in cros_ec_sensorhub.c?
>
> Thanks,
> Dmitry
prev parent reply other threads:[~2021-08-04 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 20:28 [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute after sensors are found Gwendal Grignou
2021-04-05 20:28 ` [PATCH v2 1/2] platform/chrome: Use dev_groups to set device sysfs attributes Gwendal Grignou
2021-04-05 20:28 ` [PATCH v2 2/2] platform/chrome: Update cros_ec sysfs attributes on sensors discovery Gwendal Grignou
2021-05-27 21:01 ` [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute after sensors are found Gwendal Grignou
2021-05-31 5:36 ` Dmitry Torokhov
2021-08-04 21:09 ` Gwendal Grignou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUE2utqRi9+Rb3UPE6FFRVoKDE5z+NFk1TL5Nmb7CW-VpBK=A@mail.gmail.com' \
--to=gwendal@chromium.org \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).