* [PATCH] sign-file: fix memory leak
@ 2023-05-25 8:43 Tianjia Zhang
2023-06-09 17:45 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2023-05-25 8:43 UTC (permalink / raw
To: Jarkko Sakkinen, David Howells, David Woodhouse, keyrings,
linux-kernel
Cc: Tianjia Zhang
The buffer allocated by asprintf() must be freeed.
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
scripts/sign-file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/sign-file.c b/scripts/sign-file.c
index b90fc9f7437f..94267cf72197 100644
--- a/scripts/sign-file.c
+++ b/scripts/sign-file.c
@@ -369,6 +369,7 @@ int main(int argc, char **argv)
"%s", sig_file_name);
#endif
BIO_free(b);
+ free(sig_file_name);
}
if (sign_only) {
@@ -420,8 +421,10 @@ int main(int argc, char **argv)
ERR(BIO_free(bd) < 0, "%s", dest_name);
/* Finally, if we're signing in place, replace the original. */
- if (replace_orig)
+ if (replace_orig) {
ERR(rename(dest_name, module_name) < 0, "%s", dest_name);
+ free(dest_name);
+ }
return 0;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sign-file: fix memory leak
2023-05-25 8:43 [PATCH] sign-file: fix memory leak Tianjia Zhang
@ 2023-06-09 17:45 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2023-06-09 17:45 UTC (permalink / raw
To: Tianjia Zhang, David Howells, David Woodhouse, keyrings,
linux-kernel
On Thu May 25, 2023 at 11:43 AM EEST, Tianjia Zhang wrote:
> The buffer allocated by asprintf() must be freeed.
... and it is freed by do_exit().
Short summary should really be
"sign-file: Explicitly call free(sig_file_name)"
David, what do you think of this patch is general?
Again, as an independent patch it is not really doing much at all.
Since freeing resources is a good practice, it would make sense as
a step toward doing something functionally interesting.
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> scripts/sign-file.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index b90fc9f7437f..94267cf72197 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -369,6 +369,7 @@ int main(int argc, char **argv)
> "%s", sig_file_name);
> #endif
> BIO_free(b);
> + free(sig_file_name);
> }
>
> if (sign_only) {
> @@ -420,8 +421,10 @@ int main(int argc, char **argv)
> ERR(BIO_free(bd) < 0, "%s", dest_name);
>
> /* Finally, if we're signing in place, replace the original. */
> - if (replace_orig)
> + if (replace_orig) {
> ERR(rename(dest_name, module_name) < 0, "%s", dest_name);
> + free(dest_name);
> + }
>
> return 0;
> }
> --
> 2.24.3 (Apple Git-128)
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-09 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 8:43 [PATCH] sign-file: fix memory leak Tianjia Zhang
2023-06-09 17:45 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).