From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49881C7EE45 for ; Fri, 9 Jun 2023 18:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjFISSu (ORCPT ); Fri, 9 Jun 2023 14:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjFISSm (ORCPT ); Fri, 9 Jun 2023 14:18:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC853586; Fri, 9 Jun 2023 11:18:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BF4560EE2; Fri, 9 Jun 2023 18:18:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4399CC433EF; Fri, 9 Jun 2023 18:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686334720; bh=OkmOjAVxbADsnonDXUvbpbOYXcARtzlVbMXpej3Goow=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=VHEpsPG36fQdX2HQ9TT0HQ9jlHnjzogNa/lG/M/U4MsI+8OH1QctOr/lFeVxpv00H H3jciWKo96iS5xmSem0O6kK3DoFkad3DOfv/TkT9nJy6t2lxdaCnZlucGLT7x8kX43 amZotwt2agJT2CpLoo5KlM9Wx/DaMAyIHZPO+BSpNd/7kn0D5ew8j6JNG50t6OIHqm VDSbFNl74YwT6PRF1zZY++oGKfuI2VVhgKwiaY8HtlKNHlgrqVVxiTfv0TQNgAKzPy uIIsouM91WugRN7xVTMIjD7syzE/iggxPvHdbbogiXfIizohEOprbInhYH+re8OGfr o8WrwnGESMgYg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 09 Jun 2023 21:18:32 +0300 Message-Id: Cc: , , , , , , , , "Jason Gunthorpe" , "Rob Herring" , "Frank Rowand" , "Mimi Zohar" , "Nageswara R Sastry" , "Coiby Xu" Subject: Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly available From: "Jarkko Sakkinen" To: "Jerry Snitselaar" , "Stefan Berger" X-Mailer: aerc 0.14.0 References: <20230418134409.177485-1-stefanb@linux.ibm.com> <20230418134409.177485-3-stefanb@linux.ibm.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu May 25, 2023 at 1:56 AM EEST, Jerry Snitselaar wrote: > On Tue, Apr 18, 2023 at 09:44:07AM -0400, Stefan Berger wrote: > > Simplify tpm_read_log_of() by moving reusable parts of the code into > > an inline function that makes it commonly available so it can be > > used also for kexec support. Call the new of_tpm_get_sml_parameters() > > function from the TPM Open Firmware driver. > >=20 > > Signed-off-by: Stefan Berger > > Cc: Jarkko Sakkinen > > Cc: Jason Gunthorpe > > Cc: Rob Herring > > Cc: Frank Rowand > > Reviewed-by: Mimi Zohar > > Tested-by: Nageswara R Sastry > > Tested-by: Coiby Xu > > Acked-by: Jarkko Sakkinen > >=20 > > Reviewed-by: Jerry Snitselaar If I just pick tpm only patches they won't apply so maybe TPM changes should be better separated if that is by any means possible. Open for counter proposals. Just my thoughts... I.e. I'm mainly wondering why TPM patches depend on IMA patches? BR, Jarkko