From: Manish Chopra <manishc@marvell.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'
Date: Mon, 5 Apr 2021 10:01:19 +0000 [thread overview]
Message-ID: <DM6PR18MB3388733FA76041D09B546CA8AB779@DM6PR18MB3388.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1c27abb938a430e58bd644729597015b3414d4aa.1617540100.git.christophe.jaillet@wanadoo.fr>
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, April 4, 2021 6:13 PM
> To: Ariel Elior <aelior@marvell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@marvell.com>; davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Subject: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in
> 'qede_rx_build_jumbo()'
>
> External Email
>
> ----------------------------------------------------------------------
> This ++ is confusing. It looks duplicated with the one already performed in
> 'skb_fill_page_desc()'.
>
> In fact, it is harmless. 'nr_frags' is written twice with the same value.
> Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1'
> in 'skb_fill_page_desc()'.
>
> So axe this post-increment to avoid confusion.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/qlogic/qede/qede_fp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index 102d0e0808d5..ee3e45e38cb7 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev
> *edev,
> dma_unmap_page(rxq->dev, bd->mapping,
> PAGE_SIZE, DMA_FROM_DEVICE);
>
> - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
> + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
> bd->data, rxq->rx_headroom, cur_size);
>
> skb->truesize += PAGE_SIZE;
> --
> 2.27.0
Acked-by: Manish Chopra <manishc@marvell.com>
next prev parent reply other threads:[~2021-04-05 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 12:42 [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()' Christophe JAILLET
2021-04-04 12:42 ` [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding it Christophe JAILLET
2021-04-05 10:07 ` [EXT] " Manish Chopra
2021-04-05 10:01 ` Manish Chopra [this message]
2021-04-05 20:00 ` [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()' patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR18MB3388733FA76041D09B546CA8AB779@DM6PR18MB3388.namprd18.prod.outlook.com \
--to=manishc@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).