From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933738AbcBQEuZ (ORCPT ); Tue, 16 Feb 2016 23:50:25 -0500 Received: from mail-am1on0054.outbound.protection.outlook.com ([157.56.112.54]:21248 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933169AbcBQEuX convert rfc822-to-8bit (ORCPT ); Tue, 16 Feb 2016 23:50:23 -0500 X-Greylist: delayed 9152 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Feb 2016 23:50:22 EST From: Mingkai Hu To: Bjorn Helgaas , "Shi, Yang" CC: "Mingkai.Hu@freescale.com" , "Minghuan.Lian@freescale.com" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , Rob Herring , "Pawel Moll" , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible Thread-Topic: [PATCH] PCI: layerscape: add ls2085a compatible Thread-Index: AQHRWSu/hfC6/y/sLU21dzqf3Zc6oZ8d+CIAgAABzYCAABvxgIARh81Q Date: Wed, 17 Feb 2016 02:17:47 +0000 Message-ID: References: <1453915925-19198-1-git-send-email-yang.shi@linaro.org> <20160205203858.GA11780@localhost> <56B509E5.2050602@linaro.org> <20160205222525.GA16238@localhost> In-Reply-To: <20160205222525.GA16238@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1;VI1PR04MB1456;5:ocbmzowe8QmoQhPThGHpmnaPW1FLaNgQUTJg9+qZzohT9LwWhPlo5KDiyTATYaKVAHXgM2Z9mgXV5rJDdZnamZggIlMTTZ398aPqUqAkHRuIXLju3twnKc8HLzht/z9XsEoVOluVQJ3QH6JKu4LqZg==;24:D/h/kyBmyWkZoUtksrdb+VcRkbNyGAsKQE/UvqCB7ty1fKXgZW9QTtxTZltE7nmGS9iNuEFJYhEiAQTGVZuxCgdTExaMQiMwQGzvoi6Aj0w= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1456; x-ms-office365-filtering-correlation-id: 3d0514ff-51ab-46f6-ddd8-08d337408759 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:VI1PR04MB1456;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1456; x-forefront-prvs: 085551F5A8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(13464003)(377454003)(479174004)(164054003)(4326007)(5003600100002)(50986999)(11100500001)(2906002)(5004730100002)(76176999)(5008740100001)(54356999)(33656002)(10400500002)(5002640100001)(66066001)(106116001)(40100003)(3280700002)(76576001)(122556002)(74316001)(93886004)(2900100001)(19580395003)(87936001)(77096005)(15975445007)(1096002)(19580405001)(1220700001)(2950100001)(102836003)(6116002)(3846002)(92566002)(586003)(5001960100002)(5001770100001)(86362001)(189998001)(3660700001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB1456;H:VI1PR04MB1454.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2016 02:17:47.5432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1456 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: Saturday, February 06, 2016 6:25 AM > To: Shi, Yang > Cc: Mingkai.Hu@freescale.com; Minghuan.Lian@freescale.com; > bhelgaas@google.com; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro- > kernel@lists.linaro.org; Rob Herring; Pawel Moll; Mark Rutland; Ian > Campbell; Kumar Gala; devicetree@vger.kernel.org > Subject: Re: [PATCH] PCI: layerscape: add ls2085a compatible > > On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote: > > On 2/5/2016 12:38 PM, Bjorn Helgaas wrote: > > >[+cc Rob, et al] > > > > > >On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote: > > >>The layerscape PCI host driver needs recognize ls2085a compatible > > >>when using firmware with ls2085a compatible property, otherwise the > > >>PCI bus won't be detected even though ls2085a compatible is included > by the dts. > > >> > > >>Signed-off-by: Yang Shi > > >>--- > > >> drivers/pci/host/pci-layerscape.c | 1 + > > >> 1 file changed, 1 insertion(+) > > >> > > >>diff --git a/drivers/pci/host/pci-layerscape.c > > >>b/drivers/pci/host/pci-layerscape.c > > >>index 3923bed..c40d8b2 100644 > > >>--- a/drivers/pci/host/pci-layerscape.c > > >>+++ b/drivers/pci/host/pci-layerscape.c > > >>@@ -203,6 +203,7 @@ static const struct of_device_id > ls_pcie_of_match[] = { > > >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > > >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > > >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > > >>+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > > > > >Hmm, "fsl,ls2085a-pcie" doesn't appear in > > >Documentation/devicetree/bindings/pci/. > > > > > >Aren't we supposed to add these strings to the bindings before or at > > >the same time we add them to drivers? > > > > The below patch will add it into dts and binding doc. I should > > mentioned this in the commit log. > > > > https://patchwork.kernel.org/patch/7767061/ > > OK. This is really annoying as a reviewer. To me, adding "fsl,ls2085a- > pcie" to: > > - the binding in Documentation/devicetree/bindings/pci/layerscape- > pci.txt > - the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > - the driver in drivers/pci/host/pci-layerscape.c > > are all logically related, and it would make sense to have them all in a > single patch. > > But whatever. I applied this to pci/host-layerscape for v4.6. > Bojon, I have sent version3 of the patch to add strings to the bindings and dts file. https://patchwork.kernel.org/patch/8333761/ Sorry for the delayed response due to Chinese New Year holiday. Thanks, Mingkai