From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Peter Chen <peter.chen@nxp.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-usb@vger.kernel.org,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Bastien Nocera <hadess@hadess.net>,
devicetree@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Al Cooper <alcooperx@gmail.com>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver
Date: Mon, 5 Apr 2021 13:22:36 -0700 [thread overview]
Message-ID: <YGtxjBMe3YCnCYK4@google.com> (raw)
In-Reply-To: <20210405201817.3977893-1-mka@chromium.org>
> Subject: [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver
Argh, that should have been v7 :/ Not sure if it's worth/required to
resend.
On Mon, Apr 05, 2021 at 01:18:12PM -0700, Matthias Kaehlcke wrote:
> This series adds:
> - the onboard_usb_hub_driver
> - glue in the xhci-plat driver to create the onboard_usb_hub
> platform device if needed
> - a device tree binding for the Realtek RTS5411 USB hub controller
> - device tree changes that add RTS5411 entries for the QCA SC7180
> based boards trogdor and lazor
> - a couple of stubs for platform device functions to avoid
> unresolved symbols with certain kernel configs
>
> The main issue the driver addresses is that a USB hub needs to be
> powered before it can be discovered. For discrete onboard hubs (an
> example for such a hub is the Realtek RTS5411) this is often solved
> by supplying the hub with an 'always-on' regulator, which is kind
> of a hack. Some onboard hubs may require further initialization
> steps, like changing the state of a GPIO or enabling a clock, which
> requires even more hacks. This driver creates a platform device
> representing the hub which performs the necessary initialization.
> Currently it only supports switching on a single regulator, support
> for multiple regulators or other actions can be added as needed.
> Different initialization sequences can be supported based on the
> compatible string.
>
> Besides performing the initialization the driver can be configured
> to power the hub off during system suspend. This can help to extend
> battery life on battery powered devices which have no requirements
> to keep the hub powered during suspend. The driver can also be
> configured to leave the hub powered when a wakeup capable USB device
> is connected when suspending, and power it off otherwise.
>
> Changes in v7:
> - series rebased on qcom/arm64-for-5.13
>
> Changes in v6:
> - updated summary
>
> Changes in v5:
> - cover letter added
>
> Matthias Kaehlcke (5):
> dt-bindings: usb: Add binding for Realtek RTS5411 hub controller
> USB: misc: Add onboard_usb_hub driver
> of/platform: Add stubs for of_platform_device_create/destroy()
> usb: host: xhci-plat: Create platform device for onboard hubs in
> probe()
> arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub
>
> .../sysfs-bus-platform-onboard-usb-hub | 8 +
> .../bindings/usb/realtek,rts5411.yaml | 59 +++
> MAINTAINERS | 7 +
> .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +-
> .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 11 +-
> .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 21 +-
> drivers/usb/host/xhci-plat.c | 16 +
> drivers/usb/misc/Kconfig | 17 +
> drivers/usb/misc/Makefile | 1 +
> drivers/usb/misc/onboard_usb_hub.c | 415 ++++++++++++++++++
> include/linux/of_platform.h | 22 +-
> include/linux/usb/hcd.h | 2 +
> include/linux/usb/onboard_hub.h | 15 +
> 14 files changed, 596 insertions(+), 36 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub
> create mode 100644 Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
> create mode 100644 drivers/usb/misc/onboard_usb_hub.c
> create mode 100644 include/linux/usb/onboard_hub.h
>
> --
> 2.31.0.208.g409f899ff0-goog
>
next prev parent reply other threads:[~2021-04-05 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 20:18 [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller Matthias Kaehlcke
2021-04-06 13:24 ` Rob Herring
2021-04-06 16:30 ` Rob Herring
2021-04-08 22:49 ` Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2021-04-08 15:21 ` Rob Herring
2021-04-08 23:01 ` Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 4/5] usb: host: xhci-plat: Create platform device for onboard hubs in probe() Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2021-04-05 20:22 ` Matthias Kaehlcke [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-05 19:38 [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGtxjBMe3YCnCYK4@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).