* [PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO
@ 2021-04-05 15:04 Julian Braha
2021-04-05 22:50 ` Eric Biggers
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2021-04-05 15:04 UTC (permalink / raw)
To: herbert; +Cc: linux-kernel, linux-crypto, fazilyildiran
Currently, when a config option selects a
CRYPTO_LIB_* option while CRYPTO is disabled,
Kbuild gives an unmet dependency. However,
these config options do not actually need to
depend on CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 5809cc198fa7..fb7eca5cb8c6 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1870,9 +1870,9 @@ config CRYPTO_STATS
config CRYPTO_HASH_INFO
bool
-source "lib/crypto/Kconfig"
source "drivers/crypto/Kconfig"
source "crypto/asymmetric_keys/Kconfig"
source "certs/Kconfig"
endif # if CRYPTO
+source "lib/crypto/Kconfig"
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO
2021-04-05 15:04 [PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO Julian Braha
@ 2021-04-05 22:50 ` Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2021-04-05 22:50 UTC (permalink / raw)
To: Julian Braha; +Cc: herbert, linux-kernel, linux-crypto, fazilyildiran
On Mon, Apr 05, 2021 at 11:04:38AM -0400, Julian Braha wrote:
> Currently, when a config option selects a
> CRYPTO_LIB_* option while CRYPTO is disabled,
> Kbuild gives an unmet dependency. However,
> these config options do not actually need to
> depend on CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 5809cc198fa7..fb7eca5cb8c6 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1870,9 +1870,9 @@ config CRYPTO_STATS
> config CRYPTO_HASH_INFO
> bool
>
> -source "lib/crypto/Kconfig"
> source "drivers/crypto/Kconfig"
> source "crypto/asymmetric_keys/Kconfig"
> source "certs/Kconfig"
>
> endif # if CRYPTO
> +source "lib/crypto/Kconfig"
> --
Actually some of the files in lib/crypto/ do depend on CRYPTO. For example,
there are calls to crypto_xor_cpy() and crypto_memneq(), which call functions
defined in crypto/algapi.c and crypto/memneq.c. These helper functions would
need to be moved into lib/crypto/ for this to work.
- Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-05 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 15:04 [PATCH] crypto: fix CRYPTO_LIB_* dependencies on CRYPTO Julian Braha
2021-04-05 22:50 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).