From: Phillip Potter <phil@philpotter.co.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing
Date: Tue, 6 Apr 2021 18:38:54 +0100 [thread overview]
Message-ID: <YGycrv60GeQezQ3Y@equinox> (raw)
In-Reply-To: <ba1f5946-d1ef-ee4f-4ce1-15af2b324181@gmail.com>
On Tue, Apr 06, 2021 at 07:26:29PM +0200, Eric Dumazet wrote:
>
>
> On 4/5/21 1:35 PM, Phillip Potter wrote:
> > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len
> > to match the appropriate type, using new tun_get_addr_len utility function
> > which returns appropriate address length for given type. Fixes a
> > KMSAN-found uninit-value bug reported by syzbot at:
> > https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
> >
> > Reported-by: syzbot+001516d86dbe88862cec@syzkaller.appspotmail.com
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
>
> Please give credits to people who helped.
>
> You could have :
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
>
> Or
> Diagnosed-by: Eric Dumazet <edumazet@google.com>
>
> Or at least CCed me :/
>
Dear Eric,
Please accept my apology for this oversight. It certainly wasn't
intentional on my part, and entirely down to inexperience. I will send
the patch again with Diagnosed-by.
Regards,
Phil
prev parent reply other threads:[~2021-04-06 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 11:35 [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing Phillip Potter
2021-04-05 21:59 ` David Miller
2021-04-06 10:18 ` Phillip Potter
2021-04-06 17:26 ` Eric Dumazet
2021-04-06 17:38 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGycrv60GeQezQ3Y@equinox \
--to=phil@philpotter.co.uk \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).