From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh@kernel.org>,
Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"
Date: Sat, 10 Apr 2021 14:08:24 +0200 [thread overview]
Message-ID: <YHGVOO0j2VpzounG@kroah.com> (raw)
In-Reply-To: <CAGETcx_3CYxrSBtTgRkyRJUS0kdtn3ukLYpSznY-e9O6eOe+xA@mail.gmail.com>
On Fri, Apr 09, 2021 at 12:36:36PM -0700, Saravana Kannan wrote:
> On Fri, Apr 9, 2021 at 12:26 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Wed, Apr 7, 2021 at 3:45 PM Ilya Lipnitskiy
> > <ilya.lipnitskiy@gmail.com> wrote:
> > >
> > > On Tue, Apr 6, 2021 at 6:24 PM Saravana Kannan <saravanak@google.com> wrote:
> > > >
> > > > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring <robh@kernel.org> wrote:
> > > > >
> > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kannan <saravanak@google.com> wrote:
> > > > > >
> > > > > > On Tue, Apr 6, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote:
> > > > > > >
> > > > > > > On Tue, Apr 06, 2021 at 04:09:10PM -0700, Saravana Kannan wrote:
> > > > > > > > On Mon, Apr 5, 2021 at 3:26 PM Ilya Lipnitskiy
> > > > > > > > <ilya.lipnitskiy@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > [<vendor>,]nr-gpios property is used by some GPIO drivers[0] to indicate
> > > > > > > > > the number of GPIOs present on a system, not define a GPIO. nr-gpios is
> > > > > > > > > not configured by #gpio-cells and can't be parsed along with other
> > > > > > > > > "*-gpios" properties.
> > > > > > > > >
> > > > > > > > > nr-gpios without the "<vendor>," prefix is not allowed by the DT
> > > > > > > > > spec[1], so only add exception for the ",nr-gpios" suffix and let the
> > > > > > > > > error message continue being printed for non-compliant implementations.
> > > > > > > > >
> > > > > > > > > [0]: nr-gpios is referenced in Documentation/devicetree/bindings/gpio:
> > > > > > > > > - gpio-adnp.txt
> > > > > > > > > - gpio-xgene-sb.txt
> > > > > > > > > - gpio-xlp.txt
> > > > > > > > > - snps,dw-apb-gpio.yaml
> > > > > > > > >
> > > > > > > > > [1]:
> > > > > > > > > Link: https://github.com/devicetree-org/dt-schema/blob/cb53a16a1eb3e2169ce170c071e47940845ec26e/schemas/gpio/gpio-consumer.yaml#L20
> > > > > > > > >
> > > > > > > > > Fixes errors such as:
> > > > > > > > > OF: /palmbus@300000/gpio@600: could not find phandle
> > > > > > > > >
> > > > > > > > > Fixes: 7f00be96f125 ("of: property: Add device link support for interrupt-parent, dmas and -gpio(s)")
> > > > > > > > > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> > > > > > > > > Cc: Saravana Kannan <saravanak@google.com>
> > > > > > > > > Cc: <stable@vger.kernel.org> # 5.5.x
> > > > > > > > > ---
> > > > > > > > > drivers/of/property.c | 11 ++++++++++-
> > > > > > > > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c
> > > > > > > > > index 2046ae311322..1793303e84ac 100644
> > > > > > > > > --- a/drivers/of/property.c
> > > > > > > > > +++ b/drivers/of/property.c
> > > > > > > > > @@ -1281,7 +1281,16 @@ DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL)
> > > > > > > > > DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL)
> > > > > > > > > DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
> > > > > > > > > DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
> > > > > > > > > -DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
> > > > > > > > > +
> > > > > > > > > +static struct device_node *parse_gpios(struct device_node *np,
> > > > > > > > > + const char *prop_name, int index)
> > > > > > > > > +{
> > > > > > > > > + if (!strcmp_suffix(prop_name, ",nr-gpios"))
> > > > > > > > > + return NULL;
> > > > > > > >
> > > > > > > > Ah I somehow missed this patch. This gives a blanked exception for
> > > > > > > > vendor,nr-gpios. I'd prefer explicit exceptions for all the instances
> > > > > > > > of ",nr-gpios" we are grandfathering in. Any future additions should
> > > > > > > > be rejected. Can we do that please?
> > > > > > > >
> > > > > > > > Rob, you okay with making this list more explicit?
> > > > > > >
> > > > > > > Not the kernel's job IMO. A schema is the right way to handle that.
> > > > > >
> > > > > > Ok, that's fine by me. Btw, let's land this in driver-core? I've made
> > > > > > changes there and this might cause conflicts. Not sure.
> > > > >
> > > > > It merges with linux-next fine. You'll need to resend this to Greg if
> > > > > you want to do that.
> > > > >
> > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > >
> > > > Hi Greg,
> > > >
> > > > Can you pull this into driver-core please?
> > > Do you want me to re-spin on top of driver-core? The patch is
> > > currently based on dt/next in robh/linux.git
> >
> > I did say you need to resend the patch to Greg, but since there's no
> > movement on this and I have other things to send upstream, I've
> > applied it.
>
> :'(
>
> If it's not too late, can we please drop it? I'm sure Greg would be
> okay with picking this up.
It's in Linus's tree, why does it matter who sends it in?
{sigh}
next prev parent reply other threads:[~2021-04-10 12:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 3:14 [PATCH] of: property: do not create device links from *nr-gpios Ilya Lipnitskiy
2021-04-05 20:00 ` Saravana Kannan
2021-04-05 20:10 ` Ilya Lipnitskiy
2021-04-05 20:18 ` Saravana Kannan
2021-04-05 20:55 ` Ilya Lipnitskiy
2021-04-06 17:40 ` Rob Herring
2021-04-06 19:28 ` Ilya Lipnitskiy
2021-04-06 21:28 ` Saravana Kannan
2021-04-06 22:31 ` Rob Herring
2021-04-05 22:25 ` [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios" Ilya Lipnitskiy
2021-04-06 23:09 ` Saravana Kannan
2021-04-07 0:34 ` Rob Herring
2021-04-07 0:45 ` Saravana Kannan
2021-04-07 1:10 ` Rob Herring
2021-04-07 1:24 ` Saravana Kannan
2021-04-07 20:44 ` Ilya Lipnitskiy
2021-04-09 19:26 ` Rob Herring
2021-04-09 19:36 ` Saravana Kannan
2021-04-10 12:08 ` Greg Kroah-Hartman [this message]
2021-04-10 8:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHGVOO0j2VpzounG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=ilya.lipnitskiy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).