From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Yong Zhi <yong.zhi@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices
Date: Tue, 13 Apr 2021 19:10:22 +0300 [thread overview]
Message-ID: <YHXCboJUF1VuZiKz@smile.fi.intel.com> (raw)
In-Reply-To: <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com>
On Mon, Apr 05, 2021 at 09:37:28PM +0100, Daniel Scally wrote:
> On 04/04/2021 19:14, Andy Shevchenko wrote:
> > When we continue, due to device is disabled, loop we have to drop reference count.
> > When we have an array full of devices we have to also drop the reference count.
> > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller.
> >
> > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> > Cc: Daniel Scally <djrscally@gmail.com>
> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Ah; thanks for catching those, I'm annoyed to have missed the
> acpi_dev_put() calls in particular
>
> Reviewed-by: Daniel Scally <djrscally@gmail.com>
Sakari, Mauro, can this be applied as v5.12 material, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-13 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 18:14 [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices Andy Shevchenko
2021-04-05 20:37 ` Daniel Scally
2021-04-13 16:10 ` Andy Shevchenko [this message]
2021-04-21 14:03 ` Sakari Ailus
2021-04-21 15:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHXCboJUF1VuZiKz@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).