From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3290C433ED for ; Thu, 15 Apr 2021 09:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 614FD61132 for ; Thu, 15 Apr 2021 09:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbhDOJJJ (ORCPT ); Thu, 15 Apr 2021 05:09:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:45288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232080AbhDOJJD (ORCPT ); Thu, 15 Apr 2021 05:09:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA4AC610CB; Thu, 15 Apr 2021 09:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618477719; bh=DNcJW1urQEhxebHE8EB9/vcQ74Ke7vd8CHkmoFeMQtg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qPheLIHpT2I1cdVVyOVobuXxehdE5n3YMG6xyfL3v0aaRGQHA3Z19unQfEFXHcPuk QNM37UXZhwC8ecgZAZiY2UowdlW04OwwTD1fXf9t42h04Q6VzP/r8onqf2eBdLWAjB ye1v9+ljZdx/rkwD6WwCkxVyQZjCW2y4s33HSrY0= Date: Thu, 15 Apr 2021 11:08:36 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Alexander Shishkin , Andy Shevchenko , Linux Kernel Mailing List Subject: Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16] Message-ID: References: <20210414171251.14672-1-alexander.shishkin@linux.intel.com> <20210414171251.14672-3-alexander.shishkin@linux.intel.com> <87sg3sfzl1.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 15, 2021 at 11:48:48AM +0300, Andy Shevchenko wrote: > On Thu, Apr 15, 2021 at 11:35 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote: > > > Greg Kroah-Hartman writes: > > > > > > >> Using raw buffer APIs against uuid_t / guid_t. > > > > > > > > So you want to do that, or you do not want to do that? Totally > > > > confused, > > > > > > My understanding is that: > > > 1) generate_random_uuid() use is allegedly bad even though it's in their > > > header, > > > 2) poking directly at the byte array inside uuid_t is bad, even though, > > > again, header. > > > > > > It is, indeed, not ideal. > > > > > > If agreeable, I'll update this patch to the below and respin the whole > > > series. > > > > You are showing that Andy wrote this, when you are the one that did :( > > > Anyway, I've dropped this single patch from the series and applied the > > rest. Feel free to send this patch as a stand-alone one once you have > > the authorship issues sorted out. > > Internally it was proposed by me as well, so authorship is correct. And I am supposed to know this how? Come on people, you know better than this...