* [PATCH] dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions
@ 2023-03-20 23:49 Tom Rix
2023-03-31 12:28 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-20 23:49 UTC (permalink / raw
To: gustavo.pimentel, vkoul, nathan, ndesaulniers
Cc: dmaengine, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/dma/dw-edma/dw-edma-v0-core.c:162:20: error:
unused function 'writeq_ch' [-Werror,-Wunused-function]
static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
^
drivers/dma/dw-edma/dw-edma-v0-core.c:185:19: error:
unused function 'readq_ch' [-Werror,-Wunused-function]
static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
^
These functions and their wrapping macros are not used, so remove them.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/dma/dw-edma/dw-edma-v0-core.c | 56 ---------------------------
1 file changed, 56 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index 72e79a0c0a4e..32f834a3848a 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -159,62 +159,6 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
#define GET_CH_32(dw, dir, ch, name) \
readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name))
-static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
- u64 value, void __iomem *addr)
-{
- if (dw->chip->mf == EDMA_MF_EDMA_LEGACY) {
- u32 viewport_sel;
- unsigned long flags;
-
- raw_spin_lock_irqsave(&dw->lock, flags);
-
- viewport_sel = FIELD_PREP(EDMA_V0_VIEWPORT_MASK, ch);
- if (dir == EDMA_DIR_READ)
- viewport_sel |= BIT(31);
-
- writel(viewport_sel,
- &(__dw_regs(dw)->type.legacy.viewport_sel));
- writeq(value, addr);
-
- raw_spin_unlock_irqrestore(&dw->lock, flags);
- } else {
- writeq(value, addr);
- }
-}
-
-static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
- const void __iomem *addr)
-{
- u64 value;
-
- if (dw->chip->mf == EDMA_MF_EDMA_LEGACY) {
- u32 viewport_sel;
- unsigned long flags;
-
- raw_spin_lock_irqsave(&dw->lock, flags);
-
- viewport_sel = FIELD_PREP(EDMA_V0_VIEWPORT_MASK, ch);
- if (dir == EDMA_DIR_READ)
- viewport_sel |= BIT(31);
-
- writel(viewport_sel,
- &(__dw_regs(dw)->type.legacy.viewport_sel));
- value = readq(addr);
-
- raw_spin_unlock_irqrestore(&dw->lock, flags);
- } else {
- value = readq(addr);
- }
-
- return value;
-}
-
-#define SET_CH_64(dw, dir, ch, name, value) \
- writeq_ch(dw, dir, ch, value, &(__dw_ch_regs(dw, dir, ch)->name))
-
-#define GET_CH_64(dw, dir, ch, name) \
- readq_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name))
-
/* eDMA management callbacks */
void dw_edma_v0_core_off(struct dw_edma *dw)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions
2023-03-20 23:49 [PATCH] dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions Tom Rix
@ 2023-03-31 12:28 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-03-31 12:28 UTC (permalink / raw
To: Tom Rix
Cc: gustavo.pimentel, nathan, ndesaulniers, dmaengine, linux-kernel,
llvm
On 20-03-23, 19:49, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/dw-edma/dw-edma-v0-core.c:162:20: error:
> unused function 'writeq_ch' [-Werror,-Wunused-function]
> static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
> ^
> drivers/dma/dw-edma/dw-edma-v0-core.c:185:19: error:
> unused function 'readq_ch' [-Werror,-Wunused-function]
> static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
> ^
> These functions and their wrapping macros are not used, so remove them.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-20 23:49 [PATCH] dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions Tom Rix
2023-03-31 12:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).