From: Matthew Wilcox <willy@infradead.org>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, david@redhat.com,
ying.huang@intel.com, mgorman@techsingularity.net,
baolin.wang@linux.alibaba.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Khalid Aziz <khalid@kernel.org>
Subject: Re: [PATCH v4] mm, compaction: Skip all non-migratable pages during scan
Date: Thu, 25 May 2023 21:45:34 +0100 [thread overview]
Message-ID: <ZG/I7tYY4uV/32hP@casper.infradead.org> (raw)
In-Reply-To: <ee093583-71c3-51ba-980f-0facb03b0e23@oracle.com>
On Thu, May 25, 2023 at 04:15:07PM -0400, Steven Sistare wrote:
> On 5/25/2023 3:58 PM, Matthew Wilcox wrote:
> > On Thu, May 25, 2023 at 01:15:07PM -0600, Khalid Aziz wrote:
> >> diff --git a/mm/compaction.c b/mm/compaction.c
> >> index 5a9501e0ae01..b548e05f0349 100644
> >> --- a/mm/compaction.c
> >> +++ b/mm/compaction.c
> >> @@ -764,6 +764,42 @@ static bool too_many_isolated(pg_data_t *pgdat)
> >> return too_many;
> >> }
> >>
> >> +/*
> >> + * Check if this base page should be skipped from isolation because
> >> + * it has extra refcounts that will prevent it from being migrated.
> >> + * This code is inspired by similar code in migrate_vma_check_page(),
> >> + * can_split_folio() and folio_migrate_mapping()
> >> + */
> >> +static inline bool page_has_extra_refs(struct page *page,
> >> + struct address_space *mapping)
> >> +{
> >> + unsigned long extra_refs;
> >> + struct folio *folio;
> >> +
> >> + /*
> >> + * Skip this check for pages in ZONE_MOVABLE or MIGRATE_CMA
> >> + * pages that can not be long term pinned
> >> + */
> >> + if (is_zone_movable_page(page) || is_migrate_cma_page(page))
> >> + return false;
> >> +
> >> + folio = page_folio(page);
> >> +
> >> + /*
> >> + * caller holds a ref already from get_page_unless_zero()
> >> + * which is accounted for in folio_expected_refs()
> >> + */
> >> + extra_refs = folio_expected_refs(mapping, folio);
> >> +
> >> + /*
> >> + * This is an admittedly racy check but good enough to determine
> >> + * if a page is pinned and can not be migrated
> >> + */
> >> + if ((folio_ref_count(folio) - extra_refs) > folio_mapcount(folio))
> >> + return true;
> >> + return false;
> >> +}
> >> +
> >> /**
> >> * isolate_migratepages_block() - isolate all migrate-able pages within
> >> * a single pageblock
> >> @@ -992,12 +1028,12 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> >> goto isolate_fail;
> >
> > Just out of shot, we have ...
> >
> > if (unlikely(!get_page_unless_zero(page)))
> >
> > This is the perfect opportunity to use folio_get_nontail_page() instead.
> > You get back the folio without having to cast the pointer yourself
> > or call page_folio(). Now you can use a folio throughout your new
> > function, saving a call to compound_head().
> >
> > For a followup patch, everything in this loop below this point can use
> > the folio ... that's quite a lot of change.
> >
> >> /*
> >> - * Migration will fail if an anonymous page is pinned in memory,
> >> - * so avoid taking lru_lock and isolating it unnecessarily in an
> >> - * admittedly racy check.
> >> + * Migration will fail if a page has extra refcounts
> >> + * from long term pinning preventing it from migrating,
> >> + * so avoid taking lru_lock and isolating it unnecessarily.
> >> */
> >
> > Isn't "long term pinning" the wrong description of the problem? Long term
> > pins suggest to me FOLL_LONGTERM. I think this is simple short term
> > pins that we care about here.
>
> vfio pins are held for a long time - Steve
So this is a third sense of "pinned pages" that is neither what
filesystems nor the mm means by pinned pages, but whatever it is that
vfio means by pinned pages? If only "pin" weren't such a desirable
word. Can somebody explain to me in small words what a vfio pin looks
like because I've tried reading vfio_iommu_type1_pin_pages() and I
don't recognise anything there that looks like pinning in either of
the other two senses.
next prev parent reply other threads:[~2023-05-25 20:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 19:15 [PATCH v4] mm, compaction: Skip all non-migratable pages during scan Khalid Aziz
2023-05-25 19:58 ` Matthew Wilcox
2023-05-25 20:15 ` Steven Sistare
2023-05-25 20:45 ` Matthew Wilcox [this message]
2023-05-25 21:31 ` Matthew Wilcox
2023-05-26 15:44 ` Khalid Aziz
2023-05-26 16:44 ` Matthew Wilcox
2023-05-26 16:46 ` David Hildenbrand
2023-05-26 18:46 ` Matthew Wilcox
2023-05-26 18:50 ` David Hildenbrand
2023-05-27 2:11 ` John Hubbard
2023-05-27 3:18 ` Matthew Wilcox
2023-05-28 23:49 ` John Hubbard
2023-05-29 0:31 ` Matthew Wilcox
2023-05-29 9:25 ` David Hildenbrand
2023-05-30 15:42 ` Khalid Aziz
2023-06-09 22:11 ` Andrew Morton
2023-06-09 23:28 ` Khalid Aziz
2023-05-25 20:41 ` Khalid Aziz
2023-05-29 3:01 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG/I7tYY4uV/32hP@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=khalid.aziz@oracle.com \
--cc=khalid@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=steven.sistare@oracle.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).