From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC07EC7EE26 for ; Tue, 16 May 2023 10:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232495AbjEPK7a (ORCPT ); Tue, 16 May 2023 06:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232493AbjEPK71 (ORCPT ); Tue, 16 May 2023 06:59:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60E80269E; Tue, 16 May 2023 03:59:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2EF9637A8; Tue, 16 May 2023 10:59:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 537F2C433A1; Tue, 16 May 2023 10:59:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684234765; bh=yDmK+yqmw45YeEHbaYn9dnovKktdTaUHwUWKWnf+bvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bvXo2R8S6qRD1bQKYuYZ04HLpI1ksEuzsg+rpZmri3v3a9+gCuBZxGOd4QXqKQ14V fgmOz48UwQQ3jZO15kMAemtllIgyXdW4iQbvGbfn6tOKogR6HtF2yxs6Gm98TkRlqq CRinpSOteh0tJE3RejzjoZuvuyMUJe07OeqgUuXwPA6X1gxqXSusILtkdZCPKXBFvC 2xozd+HOcNynrI/IzZoteICLXk2bVSwvDpPUrfo4Z4REaU5MCSHBsqUgW+T+NhffOr 2DrFo66AZZ03iLpRTmVt0jb/JGWS4k98btDmfMyZYooXGnPrF+92jhEmlUh6xrQd2g FRz1GuQassKMw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pysOr-0007lt-7D; Tue, 16 May 2023 12:59:25 +0200 Date: Tue, 16 May 2023 12:59:25 +0200 From: Johan Hovold To: Krishna Kurapati Cc: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, quic_harshq@quicinc.com, ahalaney@redhat.com Subject: Re: [PATCH v8 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Message-ID: References: <20230514054917.21318-1-quic_kriskura@quicinc.com> <20230514054917.21318-2-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230514054917.21318-2-quic_kriskura@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2023 at 11:19:09AM +0530, Krishna Kurapati wrote: > Add the compatible string for SC8280 Multiport USB controller from > Qualcomm. > > There are 4 power event irq interrupts supported by this controller > (one for each port of multiport). Added all the 4 as non-optional > interrupts for SC8280XP-MP > > Signed-off-by: Krishna Kurapati > --- > .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc8280xp-dwc3-mp > + then: > + properties: > + interrupts: > + maxItems: 7 > + interrupt-names: > + items: > + - const: dp_hs_phy_irq > + - const: dm_hs_phy_irq > + - const: ss_phy_irq I assume that these are only for the first port, and that you need to define these interrupts also for ports 2-4. > + - const: pwr_event_1 > + - const: pwr_event_2 > + - const: pwr_event_3 > + - const: pwr_event_4 > + > additionalProperties: false > > examples: Johan