From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] of: unittest: drop assertions for GPIO hog messages
Date: Fri, 9 Jun 2023 17:41:09 +0300 [thread overview]
Message-ID: <ZIM6BQnjxGVenI1S@smile.fi.intel.com> (raw)
In-Reply-To: <20230609143609.209373-1-brgl@bgdev.pl>
On Fri, Jun 09, 2023 at 04:36:09PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> These have now been demoted to debug and are normally hidden. Drop the
> assertions entirely.
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/of/unittest.c | 28 ----------------------------
> 1 file changed, 28 deletions(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 0060334a98a7..5386efeaf710 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1844,26 +1844,10 @@ static void __init of_unittest_overlay_gpio(void)
> unittest(overlay_data_apply("overlay_gpio_02b", NULL),
> "Adding overlay 'overlay_gpio_02b' failed\n");
>
> - /*
> - * messages are the result of the probes, after the
> - * driver is registered
> - */
> -
> - EXPECT_BEGIN(KERN_DEBUG,
> - "gpio-<<int>> (line-B-input): hogged as input\n");
> -
> - EXPECT_BEGIN(KERN_DEBUG,
> - "gpio-<<int>> (line-A-input): hogged as input\n");
> -
> ret = platform_driver_register(&unittest_gpio_driver);
> if (unittest(ret == 0, "could not register unittest gpio driver\n"))
> return;
>
> - EXPECT_END(KERN_DEBUG,
> - "gpio-<<int>> (line-A-input): hogged as input\n");
> - EXPECT_END(KERN_DEBUG,
> - "gpio-<<int>> (line-B-input): hogged as input\n");
> -
> unittest(probe_pass_count + 2 == unittest_gpio_probe_pass_count,
> "unittest_gpio_probe() failed or not called\n");
>
> @@ -1888,17 +1872,11 @@ static void __init of_unittest_overlay_gpio(void)
> probe_pass_count = unittest_gpio_probe_pass_count;
> chip_request_count = unittest_gpio_chip_request_count;
>
> - EXPECT_BEGIN(KERN_DEBUG,
> - "gpio-<<int>> (line-D-input): hogged as input\n");
> -
> /* overlay_gpio_03 contains gpio node and child gpio hog node */
>
> unittest(overlay_data_apply("overlay_gpio_03", NULL),
> "Adding overlay 'overlay_gpio_03' failed\n");
>
> - EXPECT_END(KERN_DEBUG,
> - "gpio-<<int>> (line-D-input): hogged as input\n");
> -
> unittest(probe_pass_count + 1 == unittest_gpio_probe_pass_count,
> "unittest_gpio_probe() failed or not called\n");
>
> @@ -1935,17 +1913,11 @@ static void __init of_unittest_overlay_gpio(void)
> * - processing gpio for overlay_gpio_04b
> */
>
> - EXPECT_BEGIN(KERN_DEBUG,
> - "gpio-<<int>> (line-C-input): hogged as input\n");
> -
> /* overlay_gpio_04b contains child gpio hog node */
>
> unittest(overlay_data_apply("overlay_gpio_04b", NULL),
> "Adding overlay 'overlay_gpio_04b' failed\n");
>
> - EXPECT_END(KERN_DEBUG,
> - "gpio-<<int>> (line-C-input): hogged as input\n");
> -
> unittest(chip_request_count + 1 == unittest_gpio_chip_request_count,
> "unittest_gpio_chip_request() called %d times (expected 1 time)\n",
> unittest_gpio_chip_request_count - chip_request_count);
> --
> 2.39.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-09 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 14:36 [PATCH] of: unittest: drop assertions for GPIO hog messages Bartosz Golaszewski
2023-06-09 14:41 ` Andy Shevchenko [this message]
2023-06-09 17:01 ` Rob Herring
2023-06-09 20:15 ` Bartosz Golaszewski
2023-06-15 14:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIM6BQnjxGVenI1S@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).