From: Jiri Pirko <jiri@resnulli.us>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: simon.horman@corigine.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c
Date: Fri, 9 Jun 2023 13:38:21 +0200 [thread overview]
Message-ID: <ZIMPLYi/xRih+DlC@nanopsycho> (raw)
In-Reply-To: <20230609085249.131071-1-yang.lee@linux.alibaba.com>
Fri, Jun 09, 2023 at 10:52:47AM CEST, yang.lee@linux.alibaba.com wrote:
>./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.
>
>Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464
>Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>---
> tools/net/ynl/generated/devlink-user.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/tools/net/ynl/generated/devlink-user.c b/tools/net/ynl/generated/devlink-user.c
>index c3204e20b971..18157afd7c73 100644
>--- a/tools/net/ynl/generated/devlink-user.c
>+++ b/tools/net/ynl/generated/devlink-user.c
You are patching generated file, as the path suggests.
See what the file header says:
/* Do not edit directly, auto-generated from: */
/* Documentation/netlink/specs/devlink.yaml */
>@@ -8,7 +8,6 @@
> #include "ynl.h"
> #include <linux/devlink.h>
>
>-#include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
> #include <libmnl/libmnl.h>
>--
>2.20.1.7.g153144c
>
>
next prev parent reply other threads:[~2023-06-09 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:52 [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c Yang Li
2023-06-09 8:52 ` [PATCH net-next 2/3] tools: ynl: Remove duplicated include in handshake-user.c Yang Li
2023-06-09 8:52 ` [PATCH net-next 1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c Yang Li
2023-06-09 10:40 ` [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c patchwork-bot+netdevbpf
2023-06-09 11:38 ` Jiri Pirko [this message]
2023-06-09 18:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIMPLYi/xRih+DlC@nanopsycho \
--to=jiri@resnulli.us \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).