From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC59FC7EE29 for ; Sat, 10 Jun 2023 00:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232256AbjFJAWM (ORCPT ); Fri, 9 Jun 2023 20:22:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjFJAWJ (ORCPT ); Fri, 9 Jun 2023 20:22:09 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E317E19BB; Fri, 9 Jun 2023 17:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=HZvL0AVSKR7jJKndT6J3KioN2BGrycG/XhYHqz3bYec=; b=M6n17cdFh94bT5xy9wq13Tp++S ukuZPpcYNni11peN4ClYCLcJJff98KTuzsW19AaE2yvT6/8QspesVQdXqWw22/d6H7CyTwXKrKnRN /wo4IuJoeCztNzeMnJGFkVaTpl3ZGmKiEpSe6OLnM/NwQP1fhVUHhzarPtb6q61ZZIV85BK1Hzx97 y7vW8TSon9XNJ7J5L2c3Go7foU7ZK9arvzKdtNFF3Voqm6aTuFXrdBXO4t0pFYwrSePOAfIqzInsZ VI3WTMSK5Tb4z4prXJ1IMU5OCyzJY9JsdxPq9o4fCQJHrAI3gZ2zyNrk5hjLeiDYkAk+UxiqxKinj QoDPvgCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7mMc-00HHo0-KZ; Sat, 10 Jun 2023 00:21:54 +0000 Date: Sat, 10 Jun 2023 01:21:54 +0100 From: Matthew Wilcox To: Wei-chin Tsai =?utf-8?B?KOiUoee2reaZiSk=?= Cc: "linux@armlinux.org.uk" , "linux-kernel@vger.kernel.org" , Mel Lee =?utf-8?B?KOadjuWlh+mMmik=?= , "linux-mediatek@lists.infradead.org" , wsd_upstream , "linux-arm-kernel@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "matthias.bgg@gmail.com" , Ivan Tseng =?utf-8?B?KOabvuW/l+i7kik=?= , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v1 1/1] memory: export symbols for process memory related functions Message-ID: References: <20230609110902.13799-1-Wei-chin.Tsai@mediatek.com> <5cc76704214673cf03376d9f10f61325b9ed323f.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cc76704214673cf03376d9f10f61325b9ed323f.camel@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 04:09:01PM +0000, Wei-chin Tsai (蔡維晉) wrote: > > You haven't included any users of these new exports, so the initial > > reaction is going to be negative - please include the users of these > > new symbols in your patch set. > We use these two export functions from our kernel module to get a > specific user process's memory information and heap usage. Furthermore, > we can use such information to detect the memory leak issues. > > The example code is as follows: No. You need to be submitting the code that will use the symbol *at the same time* as the patch to export the symbol. No example code showing how it could be used. Because if the user isn't compelling, the patch to export the symbol won't be applied either.