From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496DEC7EE2E for ; Sun, 11 Jun 2023 14:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233957AbjFKObp (ORCPT ); Sun, 11 Jun 2023 10:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233716AbjFKObm (ORCPT ); Sun, 11 Jun 2023 10:31:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2189510A for ; Sun, 11 Jun 2023 07:31:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91A3961037 for ; Sun, 11 Jun 2023 14:31:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82045C433D2; Sun, 11 Jun 2023 14:31:39 +0000 (UTC) Date: Sun, 11 Jun 2023 15:31:36 +0100 From: Catalin Marinas To: Baoquan He Cc: linux-kernel@vger.kernel.org, Will Deacon , horms@kernel.org, thunder.leizhen@huawei.com, John.p.donnelly@oracle.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Message-ID: References: <20230515060259.830662-1-bhe@redhat.com> <168633894002.3180904.11323833556978641615.b4-ty@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 08:15:07PM +0800, Baoquan He wrote: > On 06/09/23 at 08:30pm, Catalin Marinas wrote: > > On Mon, 15 May 2023 14:02:57 +0800, Baoquan He wrote: > > > In v5 patch, Catalin helped review and acked the patch. However, an > > > uninitialized local varilable is warned out by static checker when Will > > > tried to merge the patch. And Will complained the code flow in > > > reserve_crashkernel() is hard to follow, required to refactor. While > > > when I tried to do the refactory, I feel it's not easy, the existing > > > several cases causes that. > > > > > > [...] > > > > Applied to arm64 (for-next/kdump). > > > > I reworte some of the paragraphs in the documentation patch, removed > > some sentences to make it easier to read (some details were pretty > > obvious). Please have a look, if you think I missed something important, > > just send a patch on top. Thanks. > > > > [1/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high > > https://git.kernel.org/arm64/c/6c4dcaddbd36 > > [2/2] Documentation: add kdump.rst to present crashkernel reservation on arm64 > > https://git.kernel.org/arm64/c/03dc0e05407f > > Could you help add below code change into the document patch commit? I > forgot adding it and got warning report from lkp test robot. > > https://lore.kernel.org/oe-kbuild-all/202306110549.ynH2Juok-lkp@intel.com/ > > diff --git a/Documentation/arm64/index.rst b/Documentation/arm64/index.rst > index ae21f8118830..dcfebddb6088 100644 > --- a/Documentation/arm64/index.rst > +++ b/Documentation/arm64/index.rst > @@ -25,6 +25,7 @@ ARM64 Architecture > sve > tagged-address-abi > tagged-pointers > + kdump I've seen the warning as well. Please send a patch fixing this as I try to avoid rebasing. Also we keep this part in alphabetical order. Thanks. -- Catalin