From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2 3/3] ata: ahci_platform: Make code agnostic to OF/ACPI
Date: Tue, 13 Jun 2023 09:27:24 +0000 [thread overview]
Message-ID: <ZIg2fAMxhHgHY1Lk@kekkonen.localdomain> (raw)
In-Reply-To: <ZIc3enu+EW93WjW7@smile.fi.intel.com>
Hi Andy,
On Mon, Jun 12, 2023 at 06:19:22PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 12, 2023 at 09:06:52AM +0000, Sakari Ailus wrote:
> > On Fri, Jun 09, 2023 at 06:49:00PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > - if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci"))
> > > + if (device_is_compatible(dev, "hisilicon,hisi-ahci"))
> > > hpriv->flags |= AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ;
> > >
> > > - port = acpi_device_get_match_data(dev);
> > > + port = device_get_match_data(dev);
> >
> > There are just a handful of users for acpi_device_get_match_data() in the
> > tree. The code could be moved to acpi_fwnode_device_get_match_data() after
> > coverting these. May be out of scope of this set though.
>
> Why do we need that one if we can use device_get_match_data() directly?
That was what I wanted to point your attention to. ;-)
> It will be also flexible in case one of OF code will need something like
> this (custom info structure for the respective compatible string).
> That said, I don't think we need to change to acpi_*() whatever.
I agree.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2023-06-13 9:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 15:48 [PATCH v2 0/3] device property: Introduce device_is_compatible() Andy Shevchenko
2023-06-09 15:48 ` [PATCH v2 1/3] ACPI: Move ACPI_DEVICE_CLASS() to mod_devicetable.h Andy Shevchenko
2023-06-09 17:32 ` Rafael J. Wysocki
2023-06-12 15:21 ` Andy Shevchenko
2023-06-12 22:07 ` Damien Le Moal
2023-06-09 15:48 ` [PATCH v2 2/3] device property: Implement device_is_compatible() Andy Shevchenko
2023-06-12 7:57 ` Sakari Ailus
2023-06-13 9:45 ` Serge Semin
2023-06-13 15:14 ` Andy Shevchenko
2023-06-13 15:14 ` Andy Shevchenko
2023-06-13 19:23 ` Serge Semin
2023-06-09 15:49 ` [PATCH v2 3/3] ata: ahci_platform: Make code agnostic to OF/ACPI Andy Shevchenko
2023-06-12 8:02 ` Sakari Ailus
2023-06-12 15:20 ` Andy Shevchenko
2023-06-13 9:26 ` Sakari Ailus
2023-06-12 9:06 ` Sakari Ailus
2023-06-12 15:19 ` Andy Shevchenko
2023-06-13 9:27 ` Sakari Ailus [this message]
2023-06-13 9:52 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIg2fAMxhHgHY1Lk@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=djrscally@gmail.com \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).