* [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()
@ 2023-07-29 12:31 Yue Haibing
2023-07-30 16:01 ` Chuck Lever
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2023-07-29 12:31 UTC (permalink / raw
To: chuck.lever, jlayton, neilb, kolga, Dai.Ngo, tom, trond.myklebust,
anna, davem, edumazet, kuba, pabeni
Cc: linux-nfs, netdev, linux-kernel, Yue Haibing
rpcrdma_bc_post_recv() is never implemented since introduction in
commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index 5e5ff6784ef5..da409450dfc0 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
-int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()
2023-07-29 12:31 [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv() Yue Haibing
@ 2023-07-30 16:01 ` Chuck Lever
2023-08-01 19:45 ` Anna Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: Chuck Lever @ 2023-07-30 16:01 UTC (permalink / raw
To: anna
Cc: jlayton, neilb, kolga, Dai.Ngo, tom, trond.myklebust, anna, davem,
edumazet, kuba, pabeni, linux-nfs, netdev, linux-kernel
On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> rpcrdma_bc_post_recv() is never implemented since introduction in
> commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Anna, can you take this one?
> ---
> net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> index 5e5ff6784ef5..da409450dfc0 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
> int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
> size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
> unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
> void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
> int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
> void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> --
> 2.34.1
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()
2023-07-30 16:01 ` Chuck Lever
@ 2023-08-01 19:45 ` Anna Schumaker
0 siblings, 0 replies; 3+ messages in thread
From: Anna Schumaker @ 2023-08-01 19:45 UTC (permalink / raw
To: Chuck Lever
Cc: jlayton, neilb, kolga, Dai.Ngo, tom, trond.myklebust, davem,
edumazet, kuba, pabeni, linux-nfs, netdev, linux-kernel
On Sun, Jul 30, 2023 at 12:01 PM Chuck Lever <chuck.lever@oracle.com> wrote:
>
> On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> > rpcrdma_bc_post_recv() is never implemented since introduction in
> > commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>
> Anna, can you take this one?
Yep! Applying it now so it doesn't get lost!
Anna
>
>
> > ---
> > net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> > index 5e5ff6784ef5..da409450dfc0 100644
> > --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> > @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
> > int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
> > size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
> > unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> > -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
> > void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
> > int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
> > void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> > --
> > 2.34.1
> >
>
> --
> Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-01 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-29 12:31 [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv() Yue Haibing
2023-07-30 16:01 ` Chuck Lever
2023-08-01 19:45 ` Anna Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).