From: Tejun Heo <tj@kernel.org>
To: Audra Mitchell <aubaker@redhat.com>
Cc: Audra Mitchell <audra@redhat.com>,
linux-kernel@vger.kernel.org, raquini@redhat.com,
jiangshanlai@gmail.com, hirokazu.yamauchi.hk@hitachi.com,
Laurence Oberman <loberman@redhat.com>,
Donald Douwsma <ddouwsma@redhat.com>
Subject: Re: [PATCH] workqueue.c: Change workqueue to accept variable length name
Date: Sat, 23 Dec 2023 02:53:52 +0900 [thread overview]
Message-ID: <ZYXNMEXBnuumL3D6@mac.lan> (raw)
In-Reply-To: <CA+bDH-v6T5vvyOwsphseHwgihdGQta7TZ9tOtt-Fnij92kvU6A@mail.gmail.com>
Hello,
On Fri, Dec 22, 2023 at 10:35:03AM -0500, Audra Mitchell wrote:
> We have one concrete example from a Hitachi block device driver (notice the
> 47a1/47a2 gets
> cut off with the workqueue name):
>
> Device Workqueue Name (24char zero terminated)
> /dev/sd0279b080047a1 xfs-blockgc/sd0279b0800
> /dev/sd0279b080047a2 xfs-blockgc/sd0279b0800
I see, so it's a combination of somewhat lengthy device names and then xfs
adding a prefix to them. Neither is particularly long but the combination
is.
> I can also imagine this issue being present with nvme devices, but the
> request came from Hitachi.
> I believe it would be up to the device driver to determine if the name can
> be shortened and I've
> included Hitachi requester on this email thread.
>
> Alternatively, we could increase the size of the WQ_NAME_LEN, but it seems
> highly likely we are
> going to butt against the static size again in the future. We previously
> had variable length names
> and it seems (to me) to be the best long term path forward.
Can we just bump the length to 32 and trigger a warning if the requested
name overruns? I want to provide some pressure to limit the length of the
name so that it doesn't get too long over time. If folks bump into it and
can't find a different way to deal with it, we can get bring back the
subject.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-12-22 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 19:39 [PATCH] workqueue.c: Change workqueue to accept variable length name Audra Mitchell
2023-12-21 21:39 ` Tejun Heo
[not found] ` <CA+bDH-v6T5vvyOwsphseHwgihdGQta7TZ9tOtt-Fnij92kvU6A@mail.gmail.com>
2023-12-22 17:53 ` Tejun Heo [this message]
2024-01-09 13:29 ` Audra Mitchell
2024-01-10 20:29 ` [PATCH v2] workqueue.c: Increase workqueue name length Audra Mitchell
2024-01-10 20:47 ` Rasmus Villemoes
2024-01-10 21:52 ` Rafael Aquini
2024-01-10 22:06 ` Rasmus Villemoes
2024-01-10 22:31 ` Rafael Aquini
2024-01-10 22:45 ` Rafael Aquini
2024-01-10 22:58 ` Rasmus Villemoes
2024-01-10 22:52 ` Rasmus Villemoes
2024-01-10 23:08 ` Rafael Aquini
2024-01-15 17:08 ` [PATCH v3] " Audra Mitchell
2024-01-16 18:31 ` Tejun Heo
2024-01-17 14:40 ` Audra Mitchell
2024-01-17 17:09 ` Tejun Heo
2024-01-19 20:30 ` Audra Mitchell
2024-01-19 23:44 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYXNMEXBnuumL3D6@mac.lan \
--to=tj@kernel.org \
--cc=aubaker@redhat.com \
--cc=audra@redhat.com \
--cc=ddouwsma@redhat.com \
--cc=hirokazu.yamauchi.hk@hitachi.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=raquini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).