From: Francesco Dolcini <francesco@dolcini.it>
To: David Lin <yu-hao.lin@nxp.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it,
tsung-hsien.hsieh@nxp.com,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client mode
Date: Thu, 18 Apr 2024 08:37:54 +0200 [thread overview]
Message-ID: <ZiC_wjm79RvrC1jp@gaggiata.pivistrello.it> (raw)
In-Reply-To: <20240418060626.431202-2-yu-hao.lin@nxp.com>
On Thu, Apr 18, 2024 at 02:06:25PM +0800, David Lin wrote:
> Add host based MLME to enable WPA3 functionalities in client mode.
> This feature required a firmware with the corresponding V2 Key API
> support. The feature (WPA3) is currently enabled and verified only
> on IW416. Also, verified no regression with change when host MLME
> is disabled.
>
> Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
...
> diff --git a/drivers/net/wireless/marvell/mwifiex/util.c b/drivers/net/wireless/marvell/mwifiex/util.c
> index 745b1d925b21..3817c08a1507 100644
> --- a/drivers/net/wireless/marvell/mwifiex/util.c
> +++ b/drivers/net/wireless/marvell/mwifiex/util.c
> @@ -417,6 +456,47 @@ mwifiex_process_mgmt_packet(struct mwifiex_private *priv,
...
> + mwifiex_dbg
> + (priv->adapter, MSG,
> + "assoc: receive disassoc from %pM\n",
> + ieee_hdr->addr3);
The way you indented this does not seems kernel coding style compliant ...
however checkpatch does not complain ... so maybe I am just wrong.
In case you need to send a new version, please keep the open parenthesis together with the function name
mwifiex_dbg(priv->adapter, MSG,
"assoc: receive disassoc from %pM\n",
ieee_hdr->addr3);
(yes, it's 81 column - and it's fine).
Again, IMHO, do not send a v11 just for this trivial change.
Francesco
next prev parent reply other threads:[~2024-04-18 6:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 6:06 [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme David Lin
2024-04-18 6:06 ` [PATCH v10 1/2] wifi: mwifiex: add host mlme for client mode David Lin
2024-04-18 6:37 ` Francesco Dolcini [this message]
2024-04-18 8:24 ` [EXT] " David Lin
2024-05-23 0:53 ` Brian Norris
2024-04-18 6:06 ` [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode David Lin
2024-05-23 0:59 ` Brian Norris
2024-05-23 2:20 ` [EXT] " David Lin
2024-04-18 6:47 ` [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme Marcel Holtmann
2024-04-18 9:08 ` [EXT] " David Lin
2024-04-18 9:15 ` [EXT] " Marcel Holtmann
2024-04-19 4:00 ` David Lin
2024-04-19 21:42 ` Brian Norris
2024-04-22 8:34 ` David Lin
2024-04-23 2:29 ` David Lin
2024-04-24 8:11 ` Marcel Holtmann
2024-04-25 2:40 ` David Lin
2024-04-26 1:08 ` Brian Norris
2024-05-02 8:34 ` David Lin
2024-05-13 1:27 ` David Lin
2024-05-23 0:50 ` Brian Norris
2024-04-26 1:00 ` Brian Norris
2024-04-26 3:04 ` David Lin
2024-04-25 2:09 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiC_wjm79RvrC1jp@gaggiata.pivistrello.it \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=francesco.dolcini@toradex.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).