From: Daniel Golle <daniel@makrotopia.org>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH 0/3] net: phy: mediatek: Integrate mtk-phy-lib and add 2.5Gphy support
Date: Thu, 25 Apr 2024 04:05:55 +0100 [thread overview]
Message-ID: <ZinIk7b5jHtJXDJX@makrotopia.org> (raw)
In-Reply-To: <20240425023325.15586-1-SkyLake.Huang@mediatek.com>
Hi SkyLake,
On Thu, Apr 25, 2024 at 10:33:22AM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@mediatek.com>
>
> Re-organize MTK ethernet phy drivers and integrate common manipulations
> into mtk-phy-lib. Also, add support for build-in 2.5Gphy on MT7988.
I assume this should go to net-next. You should mention the target tree
like [PATCH net-next 0/3] and so on, in this case it's pretty obvious
though.
Generally the series looks fine and I'm glad you factored-out common
parts like the LED handling which is a great improvement also for the
older PHYs found in MT7530 and MT7531 as well as MT7621 and MT7623N.
Splitting the the 3rd patch into more atomic changes would make
reviewing a bit easier.
Also note that I've recently submitted some fixes for the LED support
which now have already been accepted to the net tree, see
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=5b5f724b05c550e10693a53a81cadca901aefd16
So it might be the best to wait for the next round of rebase of net-next
before dealing with your suggested changes to spare maintainers from
having to deal with the merge conflicts otherwise.
Generally it'd also be nice to add support for the NO_LINK rule to the
netdev trigger, as it is supported by the hardware, but that can also be
done later obviously.
Cheers
Daniel
>
> SkyLake.Huang (3):
> net: phy: mediatek: Re-organize MediaTek ethernet phy drivers
> net: phy: mediatek: Add mtk phy lib for token ring access & LED/other
> manipulations
> net: phy: mediatek: add support for built-in 2.5G ethernet PHY on
> MT7988
>
> MAINTAINERS | 7 +-
> drivers/net/phy/Kconfig | 17 +-
> drivers/net/phy/Makefile | 3 +-
> drivers/net/phy/mediatek-ge.c | 111 ----
> drivers/net/phy/mediatek/Kconfig | 33 ++
> drivers/net/phy/mediatek/Makefile | 5 +
> drivers/net/phy/mediatek/mtk-2p5ge.c | 399 +++++++++++++
> .../mtk-ge-soc.c} | 522 ++++++++----------
> drivers/net/phy/mediatek/mtk-ge.c | 191 +++++++
> drivers/net/phy/mediatek/mtk-phy-lib.c | 330 +++++++++++
> drivers/net/phy/mediatek/mtk.h | 97 ++++
> 11 files changed, 1277 insertions(+), 438 deletions(-)
> delete mode 100644 drivers/net/phy/mediatek-ge.c
> create mode 100644 drivers/net/phy/mediatek/Kconfig
> create mode 100644 drivers/net/phy/mediatek/Makefile
> create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c
> rename drivers/net/phy/{mediatek-ge-soc.c => mediatek/mtk-ge-soc.c} (79%)
> create mode 100644 drivers/net/phy/mediatek/mtk-ge.c
> create mode 100644 drivers/net/phy/mediatek/mtk-phy-lib.c
> create mode 100644 drivers/net/phy/mediatek/mtk.h
>
> --
> 2.18.0
>
prev parent reply other threads:[~2024-04-25 3:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 2:33 [PATCH 0/3] net: phy: mediatek: Integrate mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-04-25 2:33 ` [PATCH 1/3] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-04-25 15:04 ` Andrew Lunn
2024-04-26 2:27 ` kernel test robot
2024-04-25 2:33 ` [PATCH 2/3] net: phy: mediatek: Add mtk phy lib for token ring access & LED/other manipulations Sky Huang
2024-04-25 15:13 ` Andrew Lunn
2024-04-25 18:05 ` kernel test robot
2024-05-07 14:40 ` Daniel Golle
2024-05-08 12:25 ` Andrew Lunn
2024-05-08 13:09 ` Russell King (Oracle)
2024-05-08 14:02 ` Daniel Golle
2024-04-25 2:33 ` [PATCH 3/3] net: phy: mediatek: add support for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-04-25 9:01 ` Russell King (Oracle)
2024-05-08 10:56 ` SkyLake Huang (黃啟澤)
2024-05-08 12:30 ` Andrew Lunn
2024-05-08 16:21 ` Daniel Golle
2024-04-25 15:37 ` Andrew Lunn
2024-04-25 3:05 ` Daniel Golle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZinIk7b5jHtJXDJX@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).