From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8905584D3B; Thu, 25 Apr 2024 09:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714038146; cv=none; b=RtUC/YjjyASYM8tlQ1ryNYKaNaVHNv+nkgnuLV7UK5SZyopOLDbrFVCoeuInm4HLI9yABZHDd59mU6P3DU4ZRCYUBKnuj8iOSPH7z8cPtdN55ZhIHyBJoEJJ+8inXXthLfHsPGvLIOsbXTyFzU84gaDCeMLvP9scoBz/wgBipMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714038146; c=relaxed/simple; bh=lnMOWh/JzwrvYbxxMcQCVB95Qapi9p3Hv3Alg2mH8yE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QCoRd2zZI1kfJ0hS/pBrXTrlGujuRJwBzuWipTq9J8ABHIwBXSbMIanWBZuiMH8XyLU6z1FZbeo5NUj5OiYoOf3v3qHG0i6dCSf6H1vgyLwEVrAcrfaeka0gxllN0d/4Fi0ggM8L7xrLUEB/PfpONwksYvwmCmOmKaGnzR28CD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jKAUpUqN; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jKAUpUqN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714038146; x=1745574146; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lnMOWh/JzwrvYbxxMcQCVB95Qapi9p3Hv3Alg2mH8yE=; b=jKAUpUqNdNePjWfovaC4cYXDrm778qNaZlC0vsSqOPvV9N+GJhQ1fJVz GKzq4eHYLxpeDMnRDExGuHIWgNf/DNq609p3Rnphe7MA1VvmvAxg1h/uN sxqIrOJkd2hyeM1JYlz2HArjNJTJZ7LrK06DIv/gqU3QGQ1QWLSAaiG6+ wG8jtSVXafPQh0CJpcE0IR3W4KMlSkRKWut5ty4RgBFPnR73qxWNT/7kY gZYWP1TaMjzagQE0xUI0hGe0RqoK7+aTVaUd+yoFw4f+tPzaw/rMEyVuW 8MSLw2lUoFYhYnE1wOS+xMt2e3TRxVZQR9VnSpMIMGwn+2PmoNbM6BCmM g==; X-CSE-ConnectionGUID: ChP4KVsKS2SbGPlSFY0vXQ== X-CSE-MsgGUID: ZPH0inqYTYWV9iDo2bW7RQ== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9561215" X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="9561215" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:42:25 -0700 X-CSE-ConnectionGUID: jYqQxlKNR1e0XTsLqbTyqg== X-CSE-MsgGUID: dDLB5tskQ+Kr44CO8fkS0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="25639133" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:42:21 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzvcP-00000000x0K-0KsB; Thu, 25 Apr 2024 12:42:17 +0300 Date: Thu, 25 Apr 2024 12:42:16 +0300 From: Andy Shevchenko To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Jarkko Nikula , Mika Westerberg , Jan Dabros , Andi Shyti , Lee Jones , Jiawen Wu , Mengyuan Lou , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maciej Fijalkowski , Andrew Lunn , Duanqiang Wen , "open list:SYNOPSYS DESIGNWARE I2C DRIVER" , "open list:WANGXUN ETHERNET DRIVER" Subject: Re: [PATCH v2 3/4] mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h Message-ID: References: <20240425002642.2053657-1-florian.fainelli@broadcom.com> <20240425002642.2053657-4-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425002642.2053657-4-florian.fainelli@broadcom.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 24, 2024 at 05:26:41PM -0700, Florian Fainelli wrote: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. ... > +++ b/drivers/mfd/intel_quark_i2c_gpio.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include Make it a separate group after linux/* ... > #include > ...here. ... > -#define INTEL_QUARK_I2C_CONTROLLER_CLK "i2c_designware.0" > +#define INTEL_QUARK_I2C_CONTROLLER_CLK I2C_DESIGNWARE_NAME ".0" I'm not fan of this, but I think creating another macro to help with constant device instance naming might be more cumbersome and overkill. -- With Best Regards, Andy Shevchenko