From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V3] perf scripts python: Add a script to run instances of perf script in parallel
Date: Fri, 26 Apr 2024 17:34:59 -0300 [thread overview]
Message-ID: <ZiwP85A_ROwL_xJN@x1> (raw)
In-Reply-To: <1e2bee89-0a4a-42e3-9f81-bd7296cfb351@intel.com>
On Fri, Apr 26, 2024 at 06:24:12PM +0300, Adrian Hunter wrote:
> On 26/04/24 15:48, Arnaldo Carvalho de Melo wrote:
> > + python3 "${pp}" -o "${output2_dir}" --jobs 4 --verbose --per-cpu -- perf script -i "${perf_data}"
> Sorry, didn't have shellcheck installed!
Its a life saver, when I saw what it found I slapped myself in the face
for having applied that patch ;-(
> Looks good. The shellcheck page refers to bash for "${var:?}"
> but it is POSIX too.
Thanks for checking! We really need more build checks like that.
- Arnaldo
prev parent reply other threads:[~2024-04-26 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 13:32 [PATCH V3] perf scripts python: Add a script to run instances of perf script in parallel Adrian Hunter
2024-04-23 23:33 ` Andi Kleen
2024-04-24 14:15 ` Arnaldo Carvalho de Melo
2024-04-26 12:48 ` Arnaldo Carvalho de Melo
2024-04-26 15:24 ` Adrian Hunter
2024-04-26 20:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiwP85A_ROwL_xJN@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).