From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Brian Foster <bfoster@redhat.com>,
Sam Sun <samsun1006219@gmail.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
djwong@kernel.org, chandan.babu@oracle.com,
syzkaller-bugs@googlegroups.com, xrivendell7@gmail.com
Subject: Re: [Linux kernel bug] KASAN: slab-out-of-bounds Read in xlog_cksum
Date: Sat, 27 Apr 2024 07:36:47 +1000 [thread overview]
Message-ID: <Ziweb7egkq2Ltn0d@dread.disaster.area> (raw)
In-Reply-To: <ZitF8eqWEYECruXo@infradead.org>
On Thu, Apr 25, 2024 at 11:13:05PM -0700, Christoph Hellwig wrote:
> On Thu, Apr 25, 2024 at 09:57:54AM -0400, Brian Foster wrote:
> > On Thu, Apr 25, 2024 at 06:12:23AM -0700, Christoph Hellwig wrote:
> > > This triggers the workaround for really old xfsprogs putting in a
> > > bogus h_size:
> > >
> > > [ 12.101992] XFS (loop0): invalid iclog size (0 bytes), using lsunit (65536 bytes)
> > >
> > > but then calculates the log recovery buffer size based on the actual
> > > on-disk h_size value. The patch below open codes xlog_logrec_hblks and
> > > fixes this particular reproducer. But I wonder if we should limit the
> > > workaround. Brian, you don't happpen to remember how old xfsprogs had
> > > to be to require your workaround (commit a70f9fe52daa8)?
> > >
> >
> > No, but a little digging turns up xfsprogs commit 20fbd4593ff2 ("libxfs:
> > format the log with valid log record headers"), which I think is what
> > you're looking for..? That went in around v4.5 or so, so I suppose
> > anything earlier than that is affected.
>
> Thanks. I was kinda hoping we could exclude v5 file systems from that
> workaround, but it is needed way too recent for that.
Any v5 filesystem with reflink and/or rmapbt enabled can be
excluded, as they didn't get added until 4.8 or after. All new
filesystems from here on should at least have reflink enabled, so
just returning EFSCORRUPTED and aborting recovery would be fine for
those filesystems....
OTOH, I think anyone using a 6.x kernel should be using a 6.x
xfsprogs, too, so maybe we should just remove the workaround from
upstream kernels altogether?
> Maybe we can specificly check for the wrongly hardcoded
> XLOG_HEADER_CYCLE_SIZE instead of allowing any value?
We probably should do that, too.
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2024-04-26 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 11:38 [Linux kernel bug] KASAN: slab-out-of-bounds Read in xlog_cksum Sam Sun
2024-04-25 13:12 ` Christoph Hellwig
2024-04-25 13:57 ` Brian Foster
2024-04-26 6:13 ` Christoph Hellwig
2024-04-26 12:46 ` Brian Foster
2024-04-26 21:36 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziweb7egkq2Ltn0d@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=samsun1006219@gmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xrivendell7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).