From: Andrea della Porta <andrea.porta@suse.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Al Cooper <alcooperx@gmail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Jonathan Bell <jonathan@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 4/6] pinctrl: bcm: Add pinconf/pinmux controller driver for BCM2712
Date: Sat, 27 Apr 2024 13:13:50 +0200 [thread overview]
Message-ID: <Zizd7sPYOhifpTJZ@apocalypse> (raw)
In-Reply-To: <CACRpkdYmfEz-eM_R3ifGnbu6saL4Fd60D2ksyCr0SW0X6M_1VQ@mail.gmail.com>
On 15:07 Tue 16 Apr , Linus Walleij wrote:
> Hi Andrea,
>
> thanks for your patch!
>
> Some comments apart from was said already.
>
> On Sun, Apr 14, 2024 at 12:14 AM Andrea della Porta
> <andrea.porta@suse.com> wrote:
>
> > +#include <linux/pinctrl/consumer.h>
> > +#include <linux/pinctrl/machine.h>
>
> Really? Why?
>
> > +#include <linux/pinctrl/pinconf.h>
> > +#include <linux/pinctrl/pinctrl.h>
> > +#include <linux/pinctrl/pinmux.h>
> > +#include <linux/pinctrl/pinconf-generic.h>
>
> I would just expect these.
>
> > +static int bcm2712_pinctrl_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + //struct device_node *np = dev->of_node;
> > + const struct bcm_plat_data *pdata;
> > + //const struct of_device_id *match;
>
> I don't know if others commented on it but drop all commented-out code
> or make use of it.
Forgot to remove those lines. Will ve dropped in a future patch since
the pin controller driver will not be included in V2 since it's not
strictly needed to support SD boot.
Many thanks,
Andrea
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2024-04-27 11:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 22:14 [PATCH 0/6] Add support for BCM2712 SD card controller Andrea della Porta
2024-04-13 22:14 ` [PATCH 1/6] dt-bindings: pinctrl: Add support for BCM2712 pin controller Andrea della Porta
2024-04-13 23:22 ` Rob Herring
2024-04-14 6:09 ` Krzysztof Kozlowski
2024-04-14 15:45 ` Florian Fainelli
2024-04-16 12:59 ` Linus Walleij
2024-04-27 10:55 ` Andrea della Porta
2024-04-13 22:14 ` [PATCH 2/6] dt-bindings: mmc: Add support for BCM2712 SD host controller Andrea della Porta
2024-04-13 23:22 ` Rob Herring
2024-04-14 6:11 ` Krzysztof Kozlowski
2024-04-14 15:55 ` Florian Fainelli
2024-04-13 22:14 ` [PATCH 3/6] arm64: dts: broadcom: Add support for BCM2712 Andrea della Porta
2024-04-14 6:22 ` Krzysztof Kozlowski
2024-04-14 16:01 ` Florian Fainelli
2024-04-27 11:02 ` Andrea della Porta
2024-04-15 8:20 ` Stefan Wahren
2024-04-15 8:52 ` Phil Elwell
2024-04-15 9:06 ` Stefan Wahren
2024-04-15 10:43 ` Phil Elwell
2024-04-13 22:14 ` [PATCH 4/6] pinctrl: bcm: Add pinconf/pinmux controller driver " Andrea della Porta
2024-04-14 7:19 ` Christophe JAILLET
2024-04-27 11:04 ` Andrea della Porta
2024-04-14 16:00 ` Florian Fainelli
2024-04-27 11:06 ` Andrea della Porta
2024-04-16 13:07 ` Linus Walleij
2024-04-27 11:13 ` Andrea della Porta [this message]
2024-04-13 22:14 ` [PATCH 5/6] mmc: sdhci-brcmstb: Add BCM2712 support Andrea della Porta
2024-04-14 6:25 ` Krzysztof Kozlowski
2024-04-14 7:28 ` Christophe JAILLET
2024-04-14 15:53 ` Florian Fainelli
2024-04-13 22:14 ` [PATCH 6/6] mmc: sdhci-brcmstb: Add BCM2712 SD Express support Andrea della Porta
2024-04-14 7:34 ` Christophe JAILLET
2024-04-27 11:16 ` Andrea della Porta
2024-04-14 15:55 ` Florian Fainelli
2024-04-27 11:21 ` Andrea della Porta
2024-04-14 10:07 ` [PATCH 0/6] Add support for BCM2712 SD card controller Stefan Wahren
2024-05-02 9:12 ` Andrea della Porta
2024-04-14 15:54 ` Florian Fainelli
2024-04-15 18:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zizd7sPYOhifpTJZ@apocalypse \
--to=andrea.porta@suse.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jonathan@raspberrypi.com \
--cc=kamal.dasu@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).