From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
To: Guillaume Nault <gnault@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: POSSIBLE BUG: selftests/net/fcnal-test.sh: [FAIL][FIX TESTED] in vrf "bind - ns-B IPv6 LLA" test
Date: Wed, 7 Jun 2023 00:04:52 +0200 [thread overview]
Message-ID: <a3b2891d-d355-dacd-24ec-af9f8aacac57@alu.unizg.hr> (raw)
In-Reply-To: <ZH+BhFzvJkWyjBE0@debian>
[-- Attachment #1: Type: text/plain, Size: 4319 bytes --]
On 6/6/23 20:57, Guillaume Nault wrote:
> On Tue, Jun 06, 2023 at 08:07:36PM +0200, Mirsad Goran Todorovac wrote:
>> On 6/6/23 15:46, Guillaume Nault wrote:
>>> diff --git a/net/ipv6/ping.c b/net/ipv6/ping.c
>>> index c4835dbdfcff..f804c11e2146 100644
>>> --- a/net/ipv6/ping.c
>>> +++ b/net/ipv6/ping.c
>>> @@ -114,7 +114,8 @@ static int ping_v6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
>>> addr_type = ipv6_addr_type(daddr);
>>> if ((__ipv6_addr_needs_scope_id(addr_type) && !oif) ||
>>> (addr_type & IPV6_ADDR_MAPPED) ||
>>> - (oif && sk->sk_bound_dev_if && oif != sk->sk_bound_dev_if))
>>> + (oif && sk->sk_bound_dev_if && oif != sk->sk_bound_dev_if &&
>>> + l3mdev_master_ifindex_by_index(sock_net(sk), oif) != sk->sk_bound_dev_if))
>>> return -EINVAL;
>>> ipcm6_init_sk(&ipc6, np);
>>
>> The problem appears to be fixed:
>>
>> # ./fcnal-test.sh
>> [...]
>> TEST: ping out, vrf device+address bind - ns-B loopback IPv6 [ OK ]
>> TEST: ping out, vrf device+address bind - ns-B IPv6 LLA [ OK ]
>> TEST: ping in - ns-A IPv6 [ OK ]
>> [...]
>> Tests passed: 888
>> Tests failed: 0
>> #
>>
>> The test passed in both environments that manifested the bug.
>>
>> Tested-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
>
> Thanks. I'll review and post this patch (probably tomorrow).
>
>> However, test on my AMD Ubuntu 22.04 box with 6.4-rc5 commit a4d7d7011219
>> has shown additional four failed tests:
>>
>> root@host # grep -n FAIL ../fcnal-test-4.log
>> 90:TEST: ping local, VRF bind - VRF IP [FAIL]
>> 92:TEST: ping local, device bind - ns-A IP [FAIL]
>> 116:TEST: ping local, VRF bind - VRF IP [FAIL]
>> 118:TEST: ping local, device bind - ns-A IP [FAIL]
>> root@host #
>>
>> But you would probably want me to file a separate bug report?
>
> Are these new failures? Do they also happen on the -net tree?
I cannot tell if those are new for the architecture (Ubuntu 22.04 + AMD Ryzen)
However, Ubuntu's unsigned 6.3.1 generic mainline kernel is also affected.
So, it might seem like an old problem.
(If you could isolate the exact tests, I could try a bisect.)
[...]
TEST: ping local, VRF bind - ns-A IP [ OK ]
TEST: ping local, VRF bind - VRF IP [FAIL]
TEST: ping local, VRF bind - loopback [ OK ]
TEST: ping local, device bind - ns-A IP [FAIL]
TEST: ping local, device bind - VRF IP [ OK ]
[...]
SYSCTL: net.ipv4.raw_l3mdev_accept=1
[...]
TEST: ping local, VRF bind - ns-A IP [ OK ]
TEST: ping local, VRF bind - VRF IP [FAIL]
TEST: ping local, VRF bind - loopback [ OK ]
TEST: ping local, device bind - ns-A IP [FAIL]
TEST: ping local, device bind - VRF IP [ OK ]
[...]
Yes, just tested, w commit 42510dffd0e2 these are still present
in fcnal-test.sh output:
[...]
TEST: ping local, VRF bind - ns-A IP [ OK ]
TEST: ping local, VRF bind - VRF IP [FAIL]
TEST: ping local, VRF bind - loopback [ OK ]
TEST: ping local, device bind - ns-A IP [FAIL]
TEST: ping local, device bind - VRF IP [ OK ]
[...]
TEST: ping local, VRF bind - ns-A IP [ OK ]
TEST: ping local, VRF bind - VRF IP [FAIL]
TEST: ping local, VRF bind - loopback [ OK ]
TEST: ping local, device bind - ns-A IP [FAIL]
TEST: ping local, device bind - VRF IP [ OK ]
[...]
I have attached the config used and lshw.
Best regards,
Mirsad
[-- Attachment #2: config-6.4.0-rc4-net-00208-g42510dffd0e2.xz --]
[-- Type: application/x-xz, Size: 57744 bytes --]
[-- Attachment #3: lshw.txt.xz --]
[-- Type: application/x-xz, Size: 6556 bytes --]
next prev parent reply other threads:[~2023-06-06 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:17 POSSIBLE BUG: selftests/net/fcnal-test.sh: [FAIL] in vrf "bind - ns-B IPv6 LLA" test Mirsad Todorovac
2023-05-31 18:11 ` Guillaume Nault
2023-06-02 12:35 ` Mirsad Goran Todorovac
2023-06-06 6:24 ` Mirsad Goran Todorovac
2023-06-06 13:46 ` Guillaume Nault
2023-06-06 13:57 ` Mirsad Todorovac
2023-06-06 14:11 ` Guillaume Nault
2023-06-06 14:28 ` Mirsad Todorovac
2023-06-06 18:50 ` Guillaume Nault
2023-06-06 19:17 ` Mirsad Goran Todorovac
2023-06-06 19:27 ` Guillaume Nault
2023-06-06 18:07 ` POSSIBLE BUG: selftests/net/fcnal-test.sh: [FAIL][FIX TESTED] " Mirsad Goran Todorovac
2023-06-06 18:57 ` Guillaume Nault
2023-06-06 22:04 ` Mirsad Goran Todorovac [this message]
2023-06-07 16:51 ` Guillaume Nault
2023-06-08 5:37 ` Mirsad Goran Todorovac
2023-06-09 16:13 ` Guillaume Nault
2023-06-10 18:04 ` Mirsad Goran Todorovac
2023-06-14 8:47 ` Guillaume Nault
2023-06-15 20:10 ` Mirsad Goran Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b2891d-d355-dacd-24ec-af9f8aacac57@alu.unizg.hr \
--to=mirsad.todorovac@alu.unizg.hr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).