From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D823DEB64DC for ; Tue, 11 Jul 2023 16:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbjGKQfq (ORCPT ); Tue, 11 Jul 2023 12:35:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232353AbjGKQfb (ORCPT ); Tue, 11 Jul 2023 12:35:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9192129 for ; Tue, 11 Jul 2023 09:35:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8456F6155B for ; Tue, 11 Jul 2023 16:34:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 825BBC433C7; Tue, 11 Jul 2023 16:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689093291; bh=cpSt6wSp9MML3SCZgntwF/5xJMCrBIMrNErWPgETwrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qtGGN+ayDJvNn7CYl0Y6Mg8Nol64sZSdGU4J7QFWWHQhkiRUhok+ZgtO0zhzd6fI8 IwYKeAf56hI07dIlmXNAJJ+xokzwk08MJLgMD52cZ5rMNmSqAiRXM5GaL6OAxrq+Ca GX5lMtEJY+ucpQ6gRkNa/0MzBqyDLLvpjx3k6YMQJqvrC4iLB0GgVKlPfecai4fddH 52hS5OWCI4FfdYs1Qn6ZFZ/BTbJ/+/+Fo5G2dvoQmDmeD9UbUy3D8jWaM1/4vWNV5G +KmtFpmEbrXJOFav1A2qyDpkr+vyrhUlsqQj1FpwRn8DS2x2mrDXgWMKLyn8VcqTz3 a6P1FGhOpAEQg== Date: Tue, 11 Jul 2023 17:34:41 +0100 From: Mark Brown To: Hugh Dickins Cc: Lorenzo Stoakes , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> <977ddee4-35f0-fcd1-2fd-1c3057e7ea2a@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GzGnTnQhN99CmdXE" Content-Disposition: inline In-Reply-To: X-Cookie: marriage, n.: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GzGnTnQhN99CmdXE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 11, 2023 at 09:13:18AM -0700, Hugh Dickins wrote: > On Tue, 11 Jul 2023, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 09:34:42PM -0700, Hugh Dickins wrote: > > > I suppose I should ask you to try reverting this 0d1c81edc61e alone > > > from 6.5-rc1: the consistency of your bisection implies that it will > > > "fix" the issues, and it is a commit which we could drop. It makes > > > me a little nervous, applying userspace-pagetable validation to kernel > > > pagetables, so I don't want to drop it; and it would really be cargo- > > > culting to drop it without understanding. But we could drop it. > > I did look at that, it doesn't revert cleanly by itself. ... > Right, that ptep_get() wrapper on the next line came in on top. > The patch to revert just 0d1c81edc61e is this: Thanks, tried that and it's still exploding in a similar way (though this time inside a regulator call from the pinctrl code which was happening in other cases). --GzGnTnQhN99CmdXE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSthKAACgkQJNaLcl1U h9B2aAf8C8X78iHr1+jlI1B9Sc2Jl67lIJJk807nXppJ2iudYWfWYcfQEQuUHL7E K/ywaUbPz/TJ+uaIBHKvc98E3JxkSDr0SKZs2HtSv+bTNhPP3F7fyU7VG/Ea6EiC 0bSwjlSmWn4rri1K4P8TMOsdC0lpZl4yMpTLHFV64/atLAtMACpKXnpKLbc+fr3U y32n809VR2e/QlYyI0rrZ8ZWMiW8HOitDbWrXPZESI5aKWVkXvjYF9D+C/OTqxbC smxEv4tAwTAvHv9qmdZPTHoyv0dEaSIFeDVi885pDtpQjj6vb7HgmfSJBWn6tGH7 InOST+lI6sT293TXfUzBvpxuDdbY8A== =ED9C -----END PGP SIGNATURE----- --GzGnTnQhN99CmdXE--