From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbcBKMEj (ORCPT ); Thu, 11 Feb 2016 07:04:39 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:57422 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbcBKMEi (ORCPT ); Thu, 11 Feb 2016 07:04:38 -0500 Date: Thu, 11 Feb 2016 12:04:35 +0000 From: "Maciej W. Rozycki" To: Ralf Baechle CC: Daniel Wagner , , Subject: Re: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header In-Reply-To: <20160211104903.GD11091@linux-mips.org> Message-ID: References: <56BAD881.9000208@bmw-carit.de> <1455096081-7176-1-git-send-email-daniel.wagner@bmw-carit.de> <1455096081-7176-3-git-send-email-daniel.wagner@bmw-carit.de> <20160211104903.GD11091@linux-mips.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-7" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.100.200.149] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2016, Ralf Baechle wrote: > > Signed-off-by: Daniel Wagner > > Suggested-by: Maciej W. Rozycki > > Reviewed-by: Maciej W. Rozycki > > Reported-by: Fengguang Wu > > Thanks, applied. > > I'm getting a less spectacular warning from gcc 5.2: > > CC fs/proc/vmcore.o > fs/proc/vmcore.c: In function ¡parse_crash_elf64_headers¢: > fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] Yes, the temporaries still need to have their pointed types changed, to `Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change. I had it mentioned in a WIP version of my review (stating that it would verify that the correct type is used by the caller), but then deleted that part inadvertently, sigh. Daniel, sorry for the extra iteration. Maciej