From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755351AbcBCXLl (ORCPT ); Wed, 3 Feb 2016 18:11:41 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35629 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbcBCXK7 (ORCPT ); Wed, 3 Feb 2016 18:10:59 -0500 Date: Wed, 3 Feb 2016 15:10:57 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: Andrew Morton , Mel Gorman , Tetsuo Handa , Oleg Nesterov , Linus Torvalds , Hugh Dickins , Andrea Argangeli , Rik van Riel , linux-mm@kvack.org, LKML , Michal Hocko Subject: Re: [PATCH 4/5] mm, oom_reaper: report success/failure In-Reply-To: <1454505240-23446-5-git-send-email-mhocko@kernel.org> Message-ID: References: <1454505240-23446-1-git-send-email-mhocko@kernel.org> <1454505240-23446-5-git-send-email-mhocko@kernel.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Feb 2016, Michal Hocko wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 8e345126d73e..b87acdca2a41 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -420,6 +420,7 @@ static struct task_struct *oom_reaper_th; > static struct task_struct *task_to_reap; > static DECLARE_WAIT_QUEUE_HEAD(oom_reaper_wait); > > +#define K(x) ((x) << (PAGE_SHIFT-10)) > static bool __oom_reap_task(struct task_struct *tsk) > { > struct mmu_gather tlb; > @@ -476,6 +477,11 @@ static bool __oom_reap_task(struct task_struct *tsk) > } > } > tlb_finish_mmu(&tlb, 0, -1); > + pr_info("oom_reaper: reaped process :%d (%s) anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lulB\n", > + task_pid_nr(tsk), tsk->comm, > + K(get_mm_counter(mm, MM_ANONPAGES)), > + K(get_mm_counter(mm, MM_FILEPAGES)), > + K(get_mm_counter(mm, MM_SHMEMPAGES))); > up_read(&mm->mmap_sem); > > /* This is a bit misleading, it would appear that the rss values are what was reaped when in fact they represent just the values of the mm being reaped. We have already printed these values as an artifact in the kernel log. I think it would be helpful to show anon-rss after reaping, however, so we can compare to the previous anon-rss that was reported. And, I agree that leaving behind a message in the kernel log that reaping has been successful is worthwhile. So this line should just show what anon-rss is after reaping and make it clear that this is not the memory reaped.