From: Julia Lawall <julia.lawall@inria.fr>
To: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: core: align arguments with open parenthesis
Date: Mon, 5 Apr 2021 21:40:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104052138230.2981@hadrien> (raw)
In-Reply-To: <00250c746ed850f6a73ff0ad4c1735cbd019b58f.1617641790.git.martinsdecarvalhobeatriz@gmail.com>
On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote:
> Cleans up checks of "Alignment should match open parenthesis"
> in file rtw_ap.c
>
> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index ca6fec52d213..73a35b3320fe 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -439,7 +439,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
> arg[3] = psta->init_rate;
>
> DBG_871X("%s => mac_id:%d , raid:%d , shortGIrate =%d, bitmap = 0x%x\n",
> - __func__, psta->mac_id, psta->raid, shortGIrate, tx_ra_bitmap);
> + __func__, psta->mac_id, psta->raid, shortGIrate, tx_ra_bitmap);
>
> rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, rssi_level);
> } else {
> @@ -512,7 +512,7 @@ void update_bmc_sta(struct adapter *padapter)
> arg[3] = psta->init_rate;
>
> DBG_871X("%s => mac_id:%d , raid:%d , bitmap = 0x%x\n",
> - __func__, psta->mac_id, psta->raid, tx_ra_bitmap);
> + __func__, psta->mac_id, psta->raid, tx_ra_bitmap);
>
> rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0);
> }
> @@ -605,14 +605,14 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
>
> /* B0 Config LDPC Coding Capability */
> if (TEST_FLAG(phtpriv_ap->ldpc_cap, LDPC_HT_ENABLE_TX) &&
> - GET_HT_CAPABILITY_ELE_LDPC_CAP((u8 *)(&phtpriv_sta->ht_cap))) {
> + GET_HT_CAPABILITY_ELE_LDPC_CAP((u8 *)(&phtpriv_sta->ht_cap))) {
> SET_FLAG(cur_ldpc_cap, (LDPC_HT_ENABLE_TX | LDPC_HT_CAP_TX));
> DBG_871X("Enable HT Tx LDPC for STA(%d)\n", psta->aid);
> }
TEST_FLAG and SET_FLAG are not standard for the kernel, don't do anything
very interesting, and aren't even used consistently in this file. Maybe
you could get rid of them completely from the driver. In another patch,
of course.
julia
> /* B7 B8 B9 Config STBC setting */
> if (TEST_FLAG(phtpriv_ap->stbc_cap, STBC_HT_ENABLE_TX) &&
> - GET_HT_CAPABILITY_ELE_RX_STBC((u8 *)(&phtpriv_sta->ht_cap))) {
> + GET_HT_CAPABILITY_ELE_RX_STBC((u8 *)(&phtpriv_sta->ht_cap))) {
> SET_FLAG(cur_stbc_cap, (STBC_HT_ENABLE_TX | STBC_HT_CAP_TX));
> DBG_871X("Enable HT Tx STBC for STA(%d)\n", psta->aid);
> }
> @@ -1176,7 +1176,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
> );
>
> if ((psecuritypriv->wpa_pairwise_cipher & WPA_CIPHER_CCMP) ||
> - (psecuritypriv->wpa2_pairwise_cipher & WPA_CIPHER_CCMP)) {
> + (psecuritypriv->wpa2_pairwise_cipher & WPA_CIPHER_CCMP)) {
> pht_cap->ampdu_params_info |= (IEEE80211_HT_CAP_AMPDU_DENSITY & (0x07 << 2));
> } else {
> pht_cap->ampdu_params_info |= (IEEE80211_HT_CAP_AMPDU_DENSITY & 0x00);
> @@ -1233,7 +1233,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
> pmlmepriv->htpriv.ht_option = false;
>
> if ((psecuritypriv->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) ||
> - (psecuritypriv->wpa_pairwise_cipher & WPA_CIPHER_TKIP)) {
> + (psecuritypriv->wpa_pairwise_cipher & WPA_CIPHER_TKIP)) {
> /* todo: */
> /* ht_cap = false; */
> }
> @@ -1820,7 +1820,7 @@ static int rtw_ht_operation_update(struct adapter *padapter)
> }
>
> DBG_871X("%s new operation mode = 0x%X changes =%d\n",
> - __func__, pmlmepriv->ht_op_mode, op_mode_changes);
> + __func__, pmlmepriv->ht_op_mode, op_mode_changes);
>
> return op_mode_changes;
> }
> @@ -1865,7 +1865,7 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
> pmlmepriv->num_sta_no_short_preamble++;
>
> if ((pmlmeext->cur_wireless_mode > WIRELESS_11B) &&
> - (pmlmepriv->num_sta_no_short_preamble == 1)) {
> + (pmlmepriv->num_sta_no_short_preamble == 1)) {
> beacon_updated = true;
> update_beacon(padapter, 0xFF, NULL, true);
> }
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/00250c746ed850f6a73ff0ad4c1735cbd019b58f.1617641790.git.martinsdecarvalhobeatriz%40gmail.com.
>
prev parent reply other threads:[~2021-04-05 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 17:29 [PATCH 0/4] staging: rtl8723bs: core: Patchsets cleans up in rtw_ap.c Beatriz Martins de Carvalho
2021-04-05 17:29 ` [PATCH 1/4] staging: rtl8723bs: core: Removed extra blank line Beatriz Martins de Carvalho
2021-04-05 17:29 ` [PATCH 2/4] staging: rtl8723bs: core: Ending line with argument Beatriz Martins de Carvalho
2021-04-05 17:29 ` [PATCH 3/4] staging: rtl8723bs: core: reorganize characters so the lines are under 100 ch Beatriz Martins de Carvalho
2021-04-06 12:13 ` Greg KH
2021-04-06 13:14 ` Beatriz Martins de Carvalho
2021-04-05 17:29 ` [PATCH 4/4] staging: rtl8723bs: core: align arguments with open parenthesis Beatriz Martins de Carvalho
2021-04-05 19:40 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104052138230.2981@hadrien \
--to=julia.lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martinsdecarvalhobeatriz@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).