From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757557AbcAZOOZ (ORCPT ); Tue, 26 Jan 2016 09:14:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:53483 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757198AbcAZOOT (ORCPT ); Tue, 26 Jan 2016 09:14:19 -0500 Date: Tue, 26 Jan 2016 15:14:16 +0100 (CET) From: Miroslav Benes To: Torsten Duwe cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List , live-patching@vger.kernel.org, pmladek@suse.cz, jeyu@redhat.com Subject: Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2) In-Reply-To: <20160126140027.GB28664@lst.de> Message-ID: References: <20160125170459.14DB7692CE@newverein.lst.de> <20160125170804.A11DB692DD@newverein.lst.de> <20160126140027.GB28664@lst.de> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Jessica added to CC list so she is aware that there are plans to implement livepatch on ppc64le ] On Tue, 26 Jan 2016, Torsten Duwe wrote: > On Tue, Jan 26, 2016 at 11:50:25AM +0100, Miroslav Benes wrote: > > > + */ > > > +int klp_write_module_reloc(struct module *mod, unsigned long type, > > > + unsigned long loc, unsigned long value) > > > +{ > > > + /* This requires infrastructure changes; we need the loadinfos. */ > > > + pr_err("lpc_write_module_reloc not yet supported\n"); > > > > This is a nit, but there is no lpc_write_module_reloc. It should be > > klp_write_module_reloc. > > Indeed. Michael, feel free to fix this on the fly or not. It needs to > disappear anyway and be replaced with functionality. Or not at all thanks to Jessica's effort [1]. Miroslav [1] http://lkml.kernel.org/g/1452281304-28618-1-git-send-email-jeyu@redhat.com